This repository has been archived by the owner on Jul 25, 2018. It is now read-only.
feat(export): make lists and maps in spreadsheet export machine-readable #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble by exporting as JSON closes #353
maxhbr
approved these changes
May 12, 2017
| .collect(Collectors.toList()); | ||
| return joinStrings(mapEntriesAsStrings); | ||
| Map<String, Object> originalMap = nullToEmptyMap(((Map<String, Object>) fieldValue)); | ||
| Map<String, String> map = Maps.transformValues(originalMap, v -> v != null ? v.toString() : ""); |
There was a problem hiding this comment.
the function you have implemented here as lambda is already in the system as nullToEmptyString
There was a problem hiding this comment.
oops! That's embarrassing. I'll fix it.
| try { | ||
| return mapper.writeValueAsString(value); | ||
| } catch (JsonProcessingException e) { | ||
| throw new IllegalArgumentException(String.format("Cannot serialize field value %s to JSON", value), e); |
There was a problem hiding this comment.
It might be better to use no RuntimeException here, maybe use instead SW360Exception.
There was a problem hiding this comment.
Please log the exception with log.error(msg,e)
| } | ||
| return fieldValue.toString(); | ||
| } | ||
|
|
||
| private static String serializeToJson(Object value) { | ||
| ObjectMapper mapper = new ObjectMapper(); |
There was a problem hiding this comment.
It might improve performance to move the ObjectMapper to a static field
There was a problem hiding this comment.
It's a seldom used function. I wouldn't care about this performance gain at this point.
alexbrdn
added a commit
that referenced
this pull request
May 15, 2017
mcjaeger
added a commit
that referenced
this pull request
May 17, 2017
chore(export): clean up the code merged with PR #398 review-by:[email protected] tested-by:[email protected]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make lists and maps in spreadsheet export machine-readable by exporting as JSON
closes #353