SwaggerEditor@next: autocompletion works incorrectly

[char0n]

Autocompletion works inproperly on next editor. If I write e.g. aaa it shows all words which contains few a. I expect it should show only words which contains ‘aaa' in a row

Steps To Reproduce

1. Open next editor (OAS 3 or OAS 3.1)
2. Start writing e.g. 'aaa'

Expected results
I expect it should show only words which contains ‘aaa' in a row. - see screen3 and screen4(examples from SH ACE editor)

Actual results
it shows all words which contains few a - see screen1 and screen2

screen1

screen2

screen3

screen4

Ref SWG-8475

[frantuma]

@kowalczyk-krzysztof @char0n @ponelat

This APIDom PR #2954 introduces support for language service "strict" filtering, by setting enableLSPFilter: true in completionContext (within languageServiceContext):

export class ApiDOMWorker {
  static apiDOMContext = {
    validatorProviders: [],
    completionProviders: [],
    performanceLogs: false,
    logLevel: apidomLS.LogLevel.WARN,
    defaultLanguageContent: {
      namespace: 'asyncapi',
    },
    completionContext: {
      maxNumberOfItems: 100,
      enableLSPFilter: true,
    },
  };

An mentioned in swagger-api/apidom#2954 (comment) and copying from comment:

This is an opinionated behaviour, as the default for LSP completions is to leave the filtering logic to the editor/client; Monaco editor always performs fuzzy matching against the filterText value and/or the current word, and in the #4216 it still displays non "strict matching" items, which is possibly a desired behavior in many cases (e.g it still provides hints in case of typos etc).

This is quite debated though.

As a user I would probably favor the standard behavior with fuzzy matching, and IMO this would be kept disabled by default, still allowing apps to enable it, maybe even providing a user option. This is not a strong opinion though.

#4289 adds a comment/placeholder demonstrating usage, in case decision is to implement it by default we will update PR to enable the flag.

[frantuma]

For reference see also microsoft/vscode#141224 and microsoft/vscode#64367

[char0n]

As a user I would probably favor the standard behavior with fuzzy matching, and IMO this would be kept disabled by default, still allowing apps to enable it, maybe even providing a user option. This is not a strong opinion though.

Yep, I do agree with keeping the current behavior (fuzzy matching) and giving the editor-monaco-language-apidom plugin capability to configure it on mount. I'll follow up with #4289 and allow to make this configurable, with default value of false.

[char0n]

Here is a PR that enables overriding ApiDOM Context configuration options to be able to enable enableLSPFilter option to be overriden. Other ApiDOM context options are now overridable as well. Documentation is part of the PR.

#4290

[frantuma]

closing as completed in swagger-api/apidom#2954 and #4290