Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When served over HTTPS, swagger-ui should prefer HTTPS API protocol #2342

Closed
edrex opened this issue Aug 21, 2016 · 1 comment
Closed

When served over HTTPS, swagger-ui should prefer HTTPS API protocol #2342

edrex opened this issue Aug 21, 2016 · 1 comment

Comments

@edrex
Copy link

edrex commented Aug 21, 2016

Given:

  • swagger-ui v2.2.0 served over https
  • API.json with "protocols": ["http", "https"]

Expected behavior:

  • API requests should use https.

Observed behavior:

  • API requests use the first protocol supplied, http in this case, which fails due to violation of mixed content policy.

Proposed fix:

When ui is served over HTTPS, prefer HTTPS protocol for API requests.
This was referenced Aug 21, 2016
Closed
Closed
@edrex
Copy link
Author

edrex commented Aug 29, 2016

@c4milo filed an upstream issue, swagger-api/swagger-js#841.

Also, it turns out this is a duplicate of #1670.

Some related reports: #1382, #2025.

@edrex edrex closed this as completed Aug 29, 2016
WhatTheFar added a commit to WhatTheFar/open-reg-backend that referenced this issue Oct 5, 2019
@WhatTheFar
fix(swagger): swagger-ui use HTTPS schema over HTTPS
d71df2c 
issue: swagger-api/swagger-ui#2342
pr: swagger-api/swagger-js#857
WhatTheFar added a commit to WhatTheFar/senior-proj-backend that referenced this issue Oct 6, 2019
@WhatTheFar
fix(swagger): swagger-ui use HTTPS schema over HTTPS
e3a0b8f 
issue: swagger-api/swagger-ui#2342
pr: swagger-api/swagger-js#857
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edrex