Simplify formatXml

src/core/utils.js

@@ -186,24 +186,17 @@ export function formatXml (xml) {
     "other->other": 0
   }
   fn = function(ln) {
-    var fromTo, key, padding, type, types, value
-    types = {
-      single: Boolean(ln.match(/<.+\/>/)),
-      closing: Boolean(ln.match(/<\/.+>/)),
-      opening: Boolean(ln.match(/<[^!?].*>/))
-    }
-    type = ((function() {
-      var results
-      results = []
-      for (key in types) {
-        value = types[key]
-        if (value) {
-          results.push(key)
-        }
-      }
-      return results
-    })())[0]
-    type = type === void 0 ? "other" : type
+    var fromTo, padding, type
+
+    if (ln.match(/<.+\/>/)) {
+      type = "single"
+    } else if (ln.match(/<\/.+>/)) {
+      type = "closing"
+    } else if (ln.match(/<[^!?].*>/)) {
+      type = "opening"
+    } else {
+      type = "other"
+    }    
     fromTo = lastType + "->" + type
     lastType = type
     padding = ""

test/core/utils.js

@@ -17,6 +17,7 @@ import {
   getAcceptControllingResponse,
   createDeepLinkPath,
   escapeDeepLinkPath,
+  formatXml,
   sanitizeUrl
 } from "core/utils"
 import win from "core/window"
@@ -887,6 +888,16 @@ describe("utils", function() {
     })
   })
 
+  describe("formatXml", function() {
+    it("simple xml formatting", function() {
+      const startTime = Date.now()
+      const result = formatXml("<xml><name>john doe</name></xml>")
+      let duration = Date.now() - startTime
+      expect(result).toEqual("<xml>\n  <name>john doe</name>\n</xml>\n") 
+      expect(duration).toBeLessThan(5)
+    })    
+  })
+
   describe("sanitizeUrl", function() {
     it("should sanitize a `javascript:` url", function() {
       const res = sanitizeUrl("javascript:alert('bam!')")
@@ -925,4 +936,5 @@ sbG8iKTs8L3NjcmlwdD4=`)
       expect(sanitizeUrl({})).toEqual("")
     })
   })
+
 })