fix: unnecessary type field in parameter body schema

swaggo · Oct 19, 2019 · 6567f07 · 6567f07
1 parent 008c37b
commit 6567f07
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 7 deletions.
diff --git a/operation.go b/operation.go
@@ -186,7 +186,7 @@ func (operation *Operation) ParseParamComment(commentLine string, astFile *ast.F
 					SchemaProps: spec.SchemaProps{},
 				},
 			}
-			// Arrau of Primitive or Object
+			// Array of Primitive or Object
 			if IsPrimitiveType(refType) {
 				param.Schema.Items.Schema.Type = spec.StringOrArray{refType}
 			} else {
@@ -199,7 +199,7 @@ func (operation *Operation) ParseParamComment(commentLine string, astFile *ast.F
 			if err := operation.registerSchemaType(refType, astFile); err != nil {
 				return err
 			}
-			param.Schema.Type = spec.StringOrArray{objectType}
+			param.Schema.Type = []string{}
 			param.Schema.Ref = spec.Ref{
 				Ref: jsonreference.MustCreateRef("#/definitions/" + refType),
 			}

diff --git a/operation_test.go b/operation_test.go
@@ -468,7 +468,6 @@ func TestParseParamCommentByBodyType(t *testing.T) {
             "in": "body",
             "required": true,
             "schema": {
-                "type": "object",
                 "$ref": "#/definitions/model.OrderRow"
             }
         }

diff --git a/parser_test.go b/parser_test.go
@@ -378,7 +378,6 @@ func TestParseSimpleApi1(t *testing.T) {
                         "in": "body",
                         "required": true,
                         "schema": {
-                            "type": "object",
                             "$ref": "#/definitions/web.Pet"
                         }
                     }
@@ -1006,7 +1005,6 @@ func TestParseSimpleApi_ForSnakecase(t *testing.T) {
                         "in": "body",
                         "required": true,
                         "schema": {
-                            "type": "object",
                             "$ref": "#/definitions/web.Pet"
                         }
                     }
@@ -1490,7 +1488,6 @@ func TestParseSimpleApi_ForLowerCamelcase(t *testing.T) {
                         "in": "body",
                         "required": true,
                         "schema": {
-                            "type": "object",
                             "$ref": "#/definitions/web.Pet"
                         }
                     }
@@ -2046,7 +2043,6 @@ func TestParseModelNotUnderRoot(t *testing.T) {
                         "in": "body",
                         "required": true,
                         "schema": {
-                            "type": "object",
                             "$ref": "#/definitions/data.Foo"
                         }
                     }