Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor code #1539

Merged
merged 4 commits into from
Apr 5, 2023
Merged

chore: refactor code #1539

merged 4 commits into from
Apr 5, 2023

Conversation

ubogdan
Copy link
Contributor

@ubogdan ubogdan commented Apr 5, 2023

Describe the PR
Refactor code

  • remove duplication
  • use embed to store generated doc templates
  • remove code for go<1.18

Relation issue
None

Additional context
None

@ubogdan ubogdan changed the base branch from master to v2 April 5, 2023 22:49
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: +0.68 🎉

Comparison is base (7394a48) 77.11% compared to head (afae73c) 77.80%.

❗ Current head afae73c differs from pull request most recent head f666794. Consider uploading reports for the commit f666794 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #1539      +/-   ##
==========================================
+ Coverage   77.11%   77.80%   +0.68%     
==========================================
  Files          23       21       -2     
  Lines        5479     5415      -64     
==========================================
- Hits         4225     4213      -12     
+ Misses       1080     1026      -54     
- Partials      174      176       +2     
Impacted Files Coverage Δ
gen/gen.go 70.68% <27.27%> (-16.46%) ⬇️
parser.go 91.78% <100.00%> (ø)
utils.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ubogdan ubogdan merged commit 677b4c2 into v2 Apr 5, 2023
@ubogdan ubogdan deleted the refactor branch April 5, 2023 23:36
ubogdan added a commit that referenced this pull request Apr 17, 2023
* chore: refactor code

* chore: lint

* chore: lint

* chore: use embed for generated doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant