Fix isNotRecurringNestStruct function #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkly
force-pushed
the
fix-nesting-struct-test
branch
from
160459f to
b405587
Compare
Currently, the function does not use its refTypeName parameter;
instead it checks that the 1st structure in the structures stack
does not repeat. Recursion, however, can be indirect. Consider the
following example:
type Foo struct {
Bar Bar
}
type Bar struct {
Foo Foo
}
type Baz struct {
Foo Foo
}
In the example generator will crash with stack overflow while trying to
generate spec for Baz when there is no spec for Foo and Bar generated
yet.
The fix is to check that refTypeName does not repeat in the structures
stack.
nkly
force-pushed
the
fix-nesting-struct-test
branch
from
b405587 to
fd49f74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the function does not use its
refTypeNameparameter; instead it checks that the 1st structure in the structures stack does not repeat. Recursion, however, can be indirect. Consider thefollowing example:
In the example generator will crash with stack overflow while trying to generate spec for
Bazwhen there is no spec forFooandBargenerated yet.The fix is to check that
refTypeNamedoes not repeat in the structures stack.