Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix govet error #336

Merged
merged 5 commits into from
Mar 22, 2019
Merged

fix govet error #336

merged 5 commits into from
Mar 22, 2019

Conversation

pei0804
Copy link
Member

@pei0804 pei0804 commented Mar 21, 2019 •
edited
Loading

Describe the PR
fix for govet error and add go vet check.

@pei0804 pei0804 mentioned this pull request Mar 21, 2019
Closed
@codecov-io
Copy link

codecov-io commented Mar 21, 2019 •
edited
Loading

Codecov Report

Merging #336 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #336   +/-   ##
=======================================
  Coverage   87.73%   87.73%           
=======================================
  Files           7        7           
  Lines        1264     1264           
=======================================
  Hits         1109     1109           
  Misses         92       92           
  Partials       63       63

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d21dc4f...226e0fa. Read the comment docs.

@pei0804 pei0804 requested a review from easonlin404 March 21, 2019 08:40
easonlin404
easonlin404 reviewed Mar 21, 2019
View reviewed changes
Makefile Outdated
@@ -55,6 +55,7 @@ lint:
fi

for PKG in $(PACKAGES); do golint -set_exit_status $$PKG || exit 1; done;
go vet
Copy link
Member

@easonlin404 easonlin404 Mar 21, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe can add new .PHONY:vet like:

.PHONY: vet
vet:
 ($GOVET) $(PACKAGES)

Copy link
Member

@easonlin404 easonlin404 Mar 21, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and add make vet at travis script phase:

swag/.travis.yml

Lines 19 to 23 in 889705a

script:
- make fmt-check
- make lint
- make build
- make test

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@pei0804
Copy link
Member Author

pei0804 commented Mar 21, 2019

@easonlin404 review plz

easonlin404
easonlin404 approved these changes Mar 22, 2019
View reviewed changes
Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404 easonlin404 merged commit 009de0c into master Mar 22, 2019
@easonlin404 easonlin404 deleted the fix-govet-err branch March 22, 2019 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easonlin404 easonlin404 easonlin404 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pei0804 @codecov-io @easonlin404