Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor for property.go #352

Merged
merged 4 commits into from
Mar 24, 2019
Merged

refactor for property.go #352

merged 4 commits into from
Mar 24, 2019

Conversation

pei0804
Copy link
Member

@pei0804 pei0804 commented Mar 24, 2019

Describe the PR
refactor for property.go

@codecov-io
Copy link

codecov-io commented Mar 24, 2019

Codecov Report

Merging #352 into master will increase coverage by 0.16%.
The diff coverage is 96.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #352      +/-   ##
==========================================
+ Coverage   85.43%   85.59%   +0.16%     
==========================================
  Files           7        7              
  Lines        1318     1305      -13     
==========================================
- Hits         1126     1117       -9     
+ Misses        111      109       -2     
+ Partials       81       79       -2
Impacted Files Coverage Δ
parser.go 84.72% <100%> (ø) ⬆️
property.go 95.23% <96%> (+4.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3335bb4...0b401fb. Read the comment docs.

@pei0804
Copy link
Member Author

pei0804 commented Mar 24, 2019

@easonlin404 review plz.

@pei0804 pei0804 requested a review from easonlin404 March 24, 2019 09:05
@pei0804 pei0804 changed the title [WIP]refactor for property.go refactor for property.go Mar 24, 2019
Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404 easonlin404 merged commit 3320652 into master Mar 24, 2019
@easonlin404 easonlin404 deleted the fix-gocyclo-over15-2 branch March 24, 2019 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants