refactor: return error instead of panic #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #399 +/- ##
=========================================
- Coverage 85.08% 84.5% -0.59%
=========================================
Files 7 7
Lines 1321 1336 +15
=========================================
+ Hits 1124 1129 +5
- Misses 115 120 +5
- Partials 82 87 +5
Continue to review full report at Codecov.
|
easonlin404
changed the title
|
we can close #348 after merged it. |
|
Nice |
pei0804
approved these changes
May 20, 2019
Nerzal
pushed a commit
to Nerzal/swag
that referenced
this pull request
May 27, 2019
* refactor: return error instead of panic * fix fmt check * fix error check * refine getPropertyName * refine CheckSchemaType method
Nerzal
pushed a commit
to Nerzal/swag
that referenced
this pull request
Jun 8, 2019
* refactor: return error instead of panic * fix fmt check * fix error check * refine getPropertyName * refine CheckSchemaType method
Nerzal
pushed a commit
to Nerzal/swag
that referenced
this pull request
Jun 12, 2019
* refactor: return error instead of panic * fix fmt check * fix error check * refine getPropertyName * refine CheckSchemaType method
Nerzal
pushed a commit
to Nerzal/swag
that referenced
this pull request
Jun 12, 2019
* refactor: return error instead of panic * fix fmt check * fix error check * refine getPropertyName * refine CheckSchemaType method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #348