Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve test coverage #448

Merged
merged 6 commits into from
Jul 11, 2019
Merged

chore: improve test coverage #448

merged 6 commits into from
Jul 11, 2019

Conversation

ubogdan
Copy link
Contributor

@ubogdan ubogdan commented Jul 10, 2019

Describe the PR
Improve Test Coverage

Relation issue
None.

Additional context
Since property.go and schema.go seems to be done i don't see why not have 100% coverage.

@codecov-io
Copy link

codecov-io commented Jul 10, 2019

Codecov Report

Merging #448 into master will increase coverage by 0.75%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
+ Coverage   82.62%   83.37%   +0.75%     
==========================================
  Files           7        7              
  Lines        1456     1456              
==========================================
+ Hits         1203     1214      +11     
+ Misses        143      137       -6     
+ Partials      110      105       -5
Impacted Files Coverage Δ
property.go 100% <0%> (+1.53%) ⬆️
gen/gen.go 78.18% <0%> (+18.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52091f1...21e52b8. Read the comment docs.

@easonlin404 easonlin404 changed the title Improve Test Coverage chore: improve test coverage Jul 11, 2019
Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404 easonlin404 merged commit 4f5a434 into swaggo:master Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants