fully support map and optimization #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sdghchj
commented
Dec 13, 2019
•
sdghchj
commented
- optimization: parseTypeExpr return poionter to spec.Schema.
- optimization: struct parsed as definition ref, which may decrease output size.
- fully support map type, including map[string]interface{},map[string]primitive, also fix bug described in map not perfectly supported in struct #581.
2. fully support map type, including map[string]interface{},map[string]primitive.
3. optimization: struct parsed as definition ref.
Codecov Report
@@ Coverage Diff @@
## master #583 +/- ##
==========================================
- Coverage 87.45% 86.24% -1.22%
==========================================
Files 7 7
Lines 1618 1599 -19
==========================================
- Hits 1415 1379 -36
- Misses 119 136 +17
Partials 84 84
Continue to review full report at Codecov.
|
easonlin404
reviewed
Dec 13, 2019
easonlin404
reviewed
Dec 13, 2019
2.fix bug: lost schema's general information such as field extensions.
easonlin404
approved these changes
Dec 20, 2019
|
sorry for not promptly reply. @sdghchj Thank you for your contribution. 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.