Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dataTypeFormatlink link. #614

Merged
merged 1 commit into from
Jan 18, 2020
Merged

Fix dataTypeFormatlink link. #614

merged 1 commit into from
Jan 18, 2020

Conversation

idexter
Copy link
Contributor

@idexter idexter commented Jan 17, 2020 •
edited by ubogdan
Loading

Fix a link anchor #dataTypeFormat which refers nowhere.
Now it refers to OpenAPI Spec v2, to Data Types table.

Fixes #576

@idexter idexter requested a review from ubogdan January 17, 2020 16:33
@codecov-io
Copy link

codecov-io commented Jan 17, 2020 •
edited
Loading

Codecov Report

Merging #614 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #614   +/-   ##
=======================================
  Coverage   85.82%   85.82%           
=======================================
  Files           7        7           
  Lines        1693     1693           
=======================================
  Hits         1453     1453           
  Misses        150      150           
  Partials       90       90

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de5290b...7b5cb19. Read the comment docs.

ubogdan
ubogdan approved these changes Jan 18, 2020
View reviewed changes
Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan ubogdan merged commit 87eac7e into swaggo:master Jan 18, 2020
@ubogdan
Copy link
Contributor

ubogdan commented Jan 18, 2020

Thanks for contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubogdan ubogdan ubogdan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Data Type Formats link in readme.md is dead
3 participants
@idexter @codecov-io @ubogdan