Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding deep-level fields in response object #672

Merged
merged 8 commits into from
Apr 20, 2020
Merged

Overriding deep-level fields in response object #672

merged 8 commits into from
Apr 20, 2020

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented Apr 12, 2020

Describe the PR
Recursively parse content in { } to overriding deep-level fields in response object,also support map.

Relation issue
Enhancement of #650
#670
#676

@sdghchj sdghchj requested review from ubogdan and easonlin404 April 12, 2020 11:08
@codecov-io
Copy link

codecov-io commented Apr 12, 2020

Codecov Report

Merging #672 into master will decrease coverage by 0.40%.
The diff coverage is 82.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #672      +/-   ##
==========================================
- Coverage   84.90%   84.50%   -0.41%     
==========================================
  Files           7        7              
  Lines        1809     1813       +4     
==========================================
- Hits         1536     1532       -4     
- Misses        173      178       +5     
- Partials      100      103       +3     
Impacted Files Coverage Δ
operation.go 87.67% <82.50%> (-1.64%) ⬇️
parser.go 79.75% <0.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86f9d9c...8887c42. Read the comment docs.

easonlin404
easonlin404 previously approved these changes Apr 14, 2020
Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdghchj sdghchj requested review from pei0804 and easonlin404 and removed request for ubogdan and pei0804 April 15, 2020 01:16
@easonlin404 easonlin404 merged commit 593555a into swaggo:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants