-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor3: fix more than one models have the same name the from different packages #736
Conversation
Codecov Report
@@ Coverage Diff @@
## master #736 +/- ##
==========================================
- Coverage 84.48% 81.50% -2.99%
==========================================
Files 7 8 +1
Lines 1792 1665 -127
==========================================
- Hits 1514 1357 -157
- Misses 173 195 +22
- Partials 105 113 +8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@sdghchj Although this change is very a lot, I can understand the purpose you want to fix though the testing case. Thanks for the effort you're trying to keep changes the least. Awesome man. 💯 |
I have to say, I try to changes the least code, but still a lot of work, and especially repair those tests.