Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor3: fix more than one models have the same name the from different packages #736

Merged
merged 7 commits into from
Jun 14, 2020

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented Jun 13, 2020

  1. fix: more than one models have the same the from different packages
  2. fix: parse alias of alias of ……

I have to say, I try to changes the least code, but still a lot of work, and especially repair those tests.

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2020

Codecov Report

Merging #736 into master will decrease coverage by 2.98%.
The diff coverage is 72.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #736      +/-   ##
==========================================
- Coverage   84.48%   81.50%   -2.99%     
==========================================
  Files           7        8       +1     
  Lines        1792     1665     -127     
==========================================
- Hits         1514     1357     -157     
- Misses        173      195      +22     
- Partials      105      113       +8     
Impacted Files Coverage Δ
schema.go 86.74% <50.00%> (-10.08%) ⬇️
packages.go 60.83% <60.83%> (ø)
parser.go 77.12% <79.66%> (-2.64%) ⬇️
operation.go 88.46% <100.00%> (+0.89%) ⬆️
types.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a18bc9...71d91d2. Read the comment docs.

Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404
Copy link
Member

@sdghchj Although this change is very a lot, I can understand the purpose you want to fix though the testing case. Thanks for the effort you're trying to keep changes the least. Awesome man. 💯

@easonlin404 easonlin404 merged commit c5fb1a1 into master Jun 14, 2020
@easonlin404 easonlin404 deleted the refactor3 branch June 14, 2020 05:37
@sdghchj sdghchj changed the title Refactor3: fix more than one models have the same the from different packages Refactor3: fix more than one models have the same name the from different packages Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants