Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove say command one message limit #2316

Merged
merged 8 commits into from
Feb 10, 2025
Merged

Remove say command one message limit #2316

merged 8 commits into from
Feb 10, 2025

Conversation

xsebek
Copy link
Member

@xsebek xsebek commented Feb 8, 2025

Co-authored-by: Karl Ostmo [email protected]
Co-authored-by: Brent Yorgey [email protected]

@xsebek xsebek changed the title Remove say command one message limit Draft: Remove say command one message limit Feb 8, 2025
@xsebek xsebek changed the title Draft: Remove say command one message limit Remove say command one message limit Feb 9, 2025
@xsebek xsebek requested review from byorgey and kostmo February 9, 2025 11:33
robotInfo . robotMap . at rid . _Just . robotLog %= addLatestClosest loc'
return $ if hasLog && hasListen then Just rid else Nothing
forM_ maybeRidLoc $ \rid ->
robotInfo . robotMap . at rid . _Just . robotLog %= (|> m)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is simpler? (It would have been simpler before, too...)

            addToRobotLog r = evalState r $ do
              hasLog <- hasCapability $ CExecute Log
              hasListen <- hasCapability $ CExecute Listen
              rid <- use robotID
              when (hasLog && hasListen) $
                robotInfo . robotMap . at rid . _Just . robotLog %= (|> m)

@xsebek xsebek added the merge me Trigger the merge process of the Pull request. label Feb 10, 2025
@mergify mergify bot merged commit c7fda03 into main Feb 10, 2025
14 checks passed
@mergify mergify bot deleted the task/xsebek/simplify-say branch February 10, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log messages missing from "say" with multiple robots from same template
3 participants