Move parse + typecheck failures from LoadingFailure to SystemFailure
#2323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xsebek
approved these changes
Feb 10, 2025
|
Regarding
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two constructors in
LoadingFailurerepresented failures that are not necessarily limited to failures that can only happen when loading an asset, namely, parsing failures and typechecking failures. For example, we could fail to parse or typecheck a term entered at the REPL, which has nothing to do with loading an asset. This PR:SystemFailure.SystemFailureinto aLoadingFailure(via the newGeneralconstructor; name bikeshedding welcome)CustomMessageconstructor fromLoadingFailuresince now that can be achieved viaGeneral . CustomFailure.This is a preliminary refactoring moving towards a PR for #495.