-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TsExprWithTypeArgs should have type_args property instead of type_params #548
Milestone
Comments
Although this is breaking change, I fixed it as it is a correctness issue. |
kdy1
added a commit
to kdy1/swc
that referenced
this issue
Dec 31, 2019
Awesome! Happy new year, btw! |
@dsherret I fixed it. Happy new year! |
bors bot
pushed a commit
that referenced
this issue
Jan 4, 2020
Just found another occurrence of this. Similar to #548. ![image](https://user-images.githubusercontent.com/1609021/71735836-716b2d00-2e1d-11ea-8878-50d28da9fa5e.png) I'm currently going through all the types right now so you might want to hold off on merging this or doing a breaking change release until I finish that.
This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This library is very good at distinguishing type parameters from type arguments (unlike babel), but the declaration for
TsExprWithTypeArgs
should have atype_args
property rather thantype_params
at it currently does:This is a breaking change of course... looks like it was done on
NewExpr
in the past:The text was updated successfully, but these errors were encountered: