Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eval not handling bool value #5953

Closed
MrToy opened this issue Sep 26, 2022 · 1 comment · Fixed by #6756
Closed

Eval not handling bool value #5953

MrToy opened this issue Sep 26, 2022 · 1 comment · Fixed by #6756
Labels
Milestone

Comments

@MrToy
Copy link

MrToy commented Sep 26, 2022

Describe the bug

It looks like the minifier::Eval is not handling Lit::Bool value.

| Expr::Lit(l @ Lit::Num(..) | l @ Lit::Str(..) | l @ Lit::BigInt(..)) => {

Input code

const a=true;

Config

No response

Playground link

No response

Expected behavior

I just use Evaluator to guess Expr as Result of Lit, but fails in bool value.

Actual behavior

No response

Version

swc_ecma_minifier = 0.157.1

Additional context

No response

@MrToy MrToy added the C-bug label Sep 26, 2022
@kdy1 kdy1 added this to the Planned milestone Sep 26, 2022
@kdy1 kdy1 closed this as completed in #6756 Jan 6, 2023
kdy1 pushed a commit that referenced this issue Jan 6, 2023
@kdy1 kdy1 modified the milestones: Planned, v1.3.26 Jan 11, 2023
@swc-bot
Copy link
Collaborator

swc-bot commented Feb 10, 2023

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging a pull request may close this issue.

3 participants