Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish auto accessor and stage 3 decorator #7193

Closed
kdy1 opened this issue Apr 3, 2023 · 4 comments · Fixed by #7370
Closed

Finish auto accessor and stage 3 decorator #7193

kdy1 opened this issue Apr 3, 2023 · 4 comments · Fixed by #7370
Assignees
@kdy1
Labels
enhancement
Milestone
v1.3.58

Comments

@kdy1
Copy link
Member

kdy1 commented Apr 3, 2023 •
edited
Loading

Describe the feature

I implemented the stage 3 decorator partially with #6950, but I need to handle

  • logic for duplicate keys
  • auto accessors

I decided to split the PR as auto accessor is another task, and support for duplicate keys has significantly lower priority
@kdy1 kdy1 added this to the Planned milestone Apr 3, 2023
@kdy1 kdy1 self-assigned this Apr 3, 2023
@miso-belica
Copy link

Sorry for being nosy but the #5053 (reply in thread) is really confusing for me. Does this task mean finishing the whole spec of decorators as implemented in TSv5? I just want something to subscribe and know when it is done I can try swc again with my app. If this task is not the case, can you point me somewhere else, please? It seems you are the most competent person when it comes to decorators implementation in swc. Thank you for pushing this forward and your help 🙂

@yf-yang
Copy link

yf-yang commented Apr 12, 2023

@miso-belica I found this https://swc.rs/docs/configuration/compilation#jsctransformdecoratorversion, not sure when the doc was updated, in my scenario it works.

@yay
Copy link

yay commented Apr 12, 2023

@yf-yang Thanks for the link. Any idea how to use this with React SWC plugin?
vitejs/vite-plugin-react-swc#85

@yay yay mentioned this issue Apr 12, 2023
Closed
@kdy1 kdy1 mentioned this issue May 8, 2023
Merged
@fz6m fz6m mentioned this issue May 8, 2023
Merged
@kdy1 kdy1 mentioned this issue May 9, 2023
Closed
kdy1 added a commit that referenced this issue May 9, 2023
@kdy1
feat(es/compat): Partially support auto accessors (#7364)
97ec259 
**Description:**

I'll create a follow-up PR for a full support for auto accessors.

**Related issue:**

 - #7193.
@kdy1 kdy1 mentioned this issue May 9, 2023
Merged
kdy1 added a commit that referenced this issue May 15, 2023
@kdy1
feat(es/compat): Implement auto accessors fully (#7370)
cad18fa 
**Related issue:**

 - Closes #7193.
@kdy1 kdy1 modified the milestones: Planned, v1.3.58 May 15, 2023
@swc-bot
Copy link
Collaborator

swc-bot commented Jun 14, 2023

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Jun 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kdy1 kdy1

Labels
enhancement
Milestone
v1.3.58
Development

Successfully merging a pull request may close this issue.

feat(es/compat): Implement auto accessors fully kdy1/swc
5 participants
@miso-belica @yay @kdy1 @yf-yang @swc-bot