Variable named as NaN cannot be resolved

[magic-akari]

Describe the bug

Variable NaN is incorrectly renamed.

Input code

{
    let NaN = 1;
    console.log(NaN);
}

Config

{
  "jsc": {
    "minify": {
      "compress": false
    },
    "parser": {
      "syntax": "ecmascript"
    },
    "target": "es2022"
  }
}

Playground link

playground

Expected behavior

The output should be exactly the same as the input.

Actual behavior

{
    let NaN1 = 1;
    console.log(NaN);
}

Version

1.3.70

Additional context

• fix(es/minifier): Fix with and NaN #4596
• fix(es/minifier): Only cast global Infinity/undefined/NaN #7684

No response

[magic-akari]

swc/crates/swc_ecma_transforms_base/src/resolver/mod.rs

Lines 272 to 275 in 549e138

	// NaN always points the globals
	if *sym == js_word!("NaN") {
	return Some(self.config.unresolved_mark);
	}

I don't think this is true.

[kdy1]

Ah...

{
    let NaN = 1;
    console.log(NaN);
}

prints 1

and

{
    var NaN = 1;
    console.log(NaN);
}

prints NaN, so yeah, the code is wrong.

[Austaras]

NaN can be shadowed in non strict mode, but cannot be overridden.

[swc-bot]

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.