Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(hstr): Disable interning for global store #10036

Closed
wants to merge 3 commits into from
Closed

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 14, 2025

Description:

This PR disables interning for global atom store, which is invoked by using From<_> implementation of Atom, like "foo".into(). I think it's possible that interning them does not worth the cost, so I want to profile this.

Related issue:

@kdy1 kdy1 added this to the Planned milestone Feb 14, 2025
@kdy1 kdy1 self-assigned this Feb 14, 2025
Copy link

changeset-bot bot commented Feb 14, 2025

⚠️ No Changeset found

Latest commit: 7559a4c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 changed the title [Experiment] perf(hstr): Disable interning for global store perf(hstr): Disable interning for global store Feb 14, 2025
Copy link

codspeed-hq bot commented Feb 14, 2025

CodSpeed Performance Report

Merging #10036 will degrade performances by 13.66%

Comparing kdy1:hstr3 (7559a4c) with main (c28d494)

Summary

⚡ 5 improvements
❌ 12 regressions
✅ 179 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/full/minify/libraries/jquery 167.2 ms 162.2 ms +3.08%
es/full/minify/libraries/moment 106.5 ms 101 ms +5.5%
es/full/parser 1.4 ms 1.3 ms +3.59%
es/lints/libs/moment 5.7 ms 5.4 ms +5.44%
es/lints/libs/react 1.6 ms 1.9 ms -12.11%
es/minifier/libs/moment 87.5 ms 83.6 ms +4.68%
github 43.4 ms 44.7 ms -3.07%
html/document/visitor/compare/clone 1.1 ms 1.3 ms -13.41%
html/document/visitor/compare/fold_span 1.3 ms 1.5 ms -12.22%
html/document/visitor/compare/fold_span_panic 1.3 ms 1.5 ms -11.76%
html/document/visitor/compare/visit_mut_span 1.2 ms 1.4 ms -12.74%
html/document/visitor/compare/visit_mut_span_panic 1.2 ms 1.4 ms -12.83%
html/document_fragment/visitor/compare/clone 1.1 ms 1.3 ms -13.66%
html/document_fragment/visitor/compare/fold_span 1.3 ms 1.4 ms -11.76%
html/document_fragment/visitor/compare/fold_span_panic 1.3 ms 1.5 ms -12.23%
html/document_fragment/visitor/compare/visit_mut_span 1.2 ms 1.4 ms -12.53%
html/document_fragment/visitor/compare/visit_mut_span_panic 1.2 ms 1.4 ms -12.86%

@kdy1
Copy link
Member Author

kdy1 commented Feb 19, 2025

Closing as #10032 is fixed

@kdy1 kdy1 closed this Feb 19, 2025
@kdy1 kdy1 deleted the hstr3 branch February 19, 2025 03:03
@kdy1 kdy1 modified the milestones: Planned, v1.10.18 Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

hstr: Global atom store should not leak memory
1 participant