Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(es/parser): Ability to get script's potential module errors #9682

Merged

Conversation

dsherret
Copy link
Contributor

@dsherret dsherret commented Oct 28, 2024

Description:

In Deno I'm now parsing stuff as a program more often because I sometimes now need to discover if something is a script or es module by looking at the contents. A problem is that the module errors are discarded when parsing as a script, but I still might need them later if I discover the program the program should be treated as an ES module.

BREAKING CHANGE:

Adds a new method to the Tokens trait.

Related issue (if exists): None

@dsherret dsherret requested a review from a team as a code owner October 28, 2024 22:40
Copy link

changeset-bot bot commented Oct 28, 2024

🦋 Changeset detected

Latest commit: fefc73b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented Oct 29, 2024

CodSpeed Performance Report

Merging #9682 will not alter performance

Comparing dsherret:feat_parser_ability_get_script_module_errors (fefc73b) with main (2bbd1e8)

Summary

✅ 194 untouched benchmarks

@kdy1 kdy1 requested a review from a team as a code owner October 29, 2024 00:49
@kdy1 kdy1 added this to the Planned milestone Oct 29, 2024
@kdy1 kdy1 merged commit 2bbd1e8 into swc-project:main Oct 29, 2024
22 checks passed
@dsherret dsherret deleted the feat_parser_ability_get_script_module_errors branch October 29, 2024 19:18
@kdy1 kdy1 modified the milestones: Planned, v1.7.41 Oct 31, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants