Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(es/lints): Disable lints by default #9689

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 30, 2024

Description:

This is a footgun for users of swc crate. So I changed the default value of jsc.experimental.disableAllLints to true.

Related issue (if exists):

Copy link

changeset-bot bot commented Oct 30, 2024

🦋 Changeset detected

Latest commit: 6b71522

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 mentioned this pull request Oct 30, 2024
@kdy1 kdy1 marked this pull request as ready for review October 30, 2024 04:00
@kdy1 kdy1 requested review from a team as code owners October 30, 2024 04:00
@kdy1 kdy1 enabled auto-merge (squash) October 30, 2024 04:00
@kdy1 kdy1 added this to the Planned milestone Oct 30, 2024
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 30, 2024
Copy link

codspeed-hq bot commented Oct 30, 2024

CodSpeed Performance Report

Merging #9689 will degrade performances by 4.14%

Comparing kdy1:disable-lints-by-default (6b71522) with main (3597b0f)

Summary

⚡ 23 improvements
❌ 3 regressions
✅ 168 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kdy1:disable-lints-by-default Change
es/full/bugs-1 510.9 µs 474.2 µs +7.74%
es/oxc/benches/assets/UserSettings.tsx/sourceMap=false/reactDev=false 1.2 ms 1.1 ms +8.38%
es/oxc/benches/assets/UserSettings.tsx/sourceMap=false/reactDev=true 1.4 ms 1.3 ms +5.41%
es/oxc/benches/assets/UserSettings.tsx/sourceMap=true/reactDev=false 1.5 ms 1.4 ms +7.03%
es/oxc/benches/assets/UserSettings.tsx/sourceMap=true/reactDev=true 1.7 ms 1.6 ms +3.7%
es/oxc/benches/assets/parser.ts/sourceMap=false/reactDev=false 81.4 ms 76.8 ms +6.03%
es/oxc/benches/assets/parser.ts/sourceMap=false/reactDev=true 81 ms 76.8 ms +5.37%
es/oxc/benches/assets/parser.ts/sourceMap=true/reactDev=true 110.3 ms 106.3 ms +3.69%
es/oxc/benches/assets/renderer.ts/sourceMap=false/reactDev=false 13.3 ms 12.6 ms +5.72%
es/oxc/benches/assets/renderer.ts/sourceMap=false/reactDev=true 13.3 ms 12.6 ms +5.64%
es/oxc/benches/assets/renderer.ts/sourceMap=true/reactDev=false 17.8 ms 17.1 ms +4.02%
es/oxc/benches/assets/renderer.ts/sourceMap=true/reactDev=true 17.6 ms 17 ms +3.71%
es/oxc/benches/assets/table.tsx/sourceMap=false/reactDev=false 7.2 ms 6.9 ms +4.82%
es/oxc/benches/assets/table.tsx/sourceMap=false/reactDev=true 8.1 ms 7.8 ms +4.11%
es/full/base/fixer 297.4 µs 117.4 µs ×2.5
es/full/all/es2015 204.2 ms 192.2 ms +6.29%
es/full/all/es2016 202.6 ms 190.5 ms +6.39%
es/full/all/es2017 202 ms 189.9 ms +6.37%
es/full/all/es2018 200.4 ms 188.2 ms +6.46%
es/full/all/es2019 199.4 ms 187.4 ms +6.41%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@kdy1 kdy1 merged commit 4d887d0 into swc-project:main Oct 30, 2024
151 of 152 checks passed
@kdy1 kdy1 deleted the disable-lints-by-default branch October 30, 2024 05:19
@kdy1 kdy1 modified the milestones: Planned, v1.7.41 Oct 31, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant