Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/minifier): Drop console in optional chainings #9759

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

CPunisher
Copy link
Member

@CPunisher CPunisher commented Nov 25, 2024

Description:

Related issue:

@CPunisher CPunisher requested a review from a team as a code owner November 25, 2024 04:33
Copy link

changeset-bot bot commented Nov 25, 2024

🦋 Changeset detected

Latest commit: be833a9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 added this to the Planned milestone Nov 25, 2024
@kdy1 kdy1 requested a review from a team as a code owner November 25, 2024 04:46
@kdy1 kdy1 changed the title fix(es/minifier): drop console in opt chains fix(es/minifier): Drop console in optional chainings Nov 25, 2024
@kdy1 kdy1 enabled auto-merge (squash) November 25, 2024 04:47
@kdy1 kdy1 merged commit 39271ad into swc-project:main Nov 25, 2024
151 of 152 checks passed
Copy link

codspeed-hq bot commented Nov 25, 2024

CodSpeed Performance Report

Merging #9759 will not alter performance

Comparing CPunisher:fix/drop-opt-console (be833a9) with main (e0fdd68)

Summary

✅ 194 untouched benchmarks

@kdy1 kdy1 modified the milestones: Planned, v1.10.0 Dec 2, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Jan 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

console?.log('') not dropped during minify
2 participants