Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore Instructor Notes from archive #69

Merged
merged 4 commits into from
Feb 4, 2025
Merged

Conversation

tobyhodges
Copy link
Member

For some reason, the transition to the Workbench did not bring the previous version of the Instructor Notes page with it for this lesson. This PR restores the page from the version of the lesson released just before the transition was made.

@tobyhodges tobyhodges marked this pull request as draft May 4, 2023 13:33
@github-actions
Copy link

github-actions bot commented May 4, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/shell-novice-es/compare/md-outputs..md-outputs-PR-69

The following changes were observed in the rendered markdown documents:

 instructor-notes.md | 252 +++++++++++++++++++++++++++++++++++++++++++++++++++-
 md5sum.txt          |   2 +-
 2 files changed, 252 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-05-04 14:46:45 +0000

@tobyhodges tobyhodges marked this pull request as ready for review May 4, 2023 13:37
github-actions bot pushed a commit that referenced this pull request May 4, 2023
github-actions bot pushed a commit that referenced this pull request May 4, 2023
@zkamvar
Copy link
Contributor

zkamvar commented May 4, 2023

I apologise for this. It was a cryptic error that I missed.

There was a link in the guide that had spaces around the link elements:

    [Navegación de archivos y directorios] ({{page.root}} / 02-filedir /) sección) puede ser confuso. Puede tener el explorador de archivos de la GUI y la terminal abierto uno al lado del otro para que los alumnos puedan ver el contenido y la estructura del archivo mientras usan la terminal para navegar por el sistema.

When the transition workflow tried to fix this link, it threw an error that was very easy to miss:

! Could not process '/swcarpentry/shell-novice-es/_extras/guide.md': In index: 2.
! Could not process 'swcarpentry/shell-novice-es/_extras/exercises.md': the file 'swcarpentry/shell-novice-es/_extras/exercises.md' does not exist

fix links
Co-authored-by: Zhian N. Kamvar <[email protected]>
github-actions bot pushed a commit that referenced this pull request May 4, 2023
@Helysalgado Helysalgado merged commit c9c8235 into main Feb 4, 2025
@Helysalgado Helysalgado deleted the restore-instructor-notes branch February 4, 2025 05:56
github-actions bot pushed a commit that referenced this pull request Feb 4, 2025
Auto-generated via `{sandpaper}`
Source  : c9c8235
Branch  : main
Author  : HeladiaSalgado <[email protected]>
Time    : 2025-02-04 05:56:54 +0000
Message : Merge pull request #69 from swcarpentry/restore-instructor-notes

restore Instructor Notes from archive
github-actions bot pushed a commit that referenced this pull request Feb 4, 2025
Auto-generated via `{sandpaper}`
Source  : 4cca1d8
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-02-04 05:57:33 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c9c8235
Branch  : main
Author  : HeladiaSalgado <[email protected]>
Time    : 2025-02-04 05:56:54 +0000
Message : Merge pull request #69 from swcarpentry/restore-instructor-notes

restore Instructor Notes from archive
github-actions bot pushed a commit that referenced this pull request Feb 11, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Auto-generated via `{sandpaper}`
Source  : c9c8235
Branch  : main
Author  : HeladiaSalgado <[email protected]>
Time    : 2025-02-04 05:56:54 +0000
Message : Merge pull request #69 from swcarpentry/restore-instructor-notes

restore Instructor Notes from archive
github-actions bot pushed a commit that referenced this pull request Feb 11, 2025
Auto-generated via `{sandpaper}`
Source  : bd5eb9f
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-02-11 00:21:29 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c9c8235
Branch  : main
Author  : HeladiaSalgado <[email protected]>
Time    : 2025-02-04 05:56:54 +0000
Message : Merge pull request #69 from swcarpentry/restore-instructor-notes

restore Instructor Notes from archive
github-actions bot pushed a commit that referenced this pull request Feb 18, 2025
Auto-generated via `{sandpaper}`
Source  : bd5eb9f
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-02-11 00:21:29 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c9c8235
Branch  : main
Author  : HeladiaSalgado <[email protected]>
Time    : 2025-02-04 05:56:54 +0000
Message : Merge pull request #69 from swcarpentry/restore-instructor-notes

restore Instructor Notes from archive
github-actions bot pushed a commit that referenced this pull request Mar 4, 2025
Auto-generated via `{sandpaper}`
Source  : bd5eb9f
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-02-11 00:21:29 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : c9c8235
Branch  : main
Author  : HeladiaSalgado <[email protected]>
Time    : 2025-02-04 05:56:54 +0000
Message : Merge pull request #69 from swcarpentry/restore-instructor-notes

restore Instructor Notes from archive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants