Fix newline outputs for django's log parser #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Sweet, thanks a bunch @xingyaoww for this contribution! Yeah, the Django output parsing for tests is a bit weird, this definitely catches a few that aren't covered by the existing parser. Hopefully there aren't any more! |
john-b-yang
approved these changes
Jul 2, 2024
This was referenced Jul 2, 2024
sreekarmolakalapalli
pushed a commit
to Modelcode-ai/SWE-bench
that referenced
this pull request
Aug 14, 2024
…-parsing Fix newline outputs for django's log parser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fix #165.
What does this implement/fix? Explain your changes.
Tries to parse test case multi-line outputs, similar to the one shown in #165 that breaks the test case parsing.
Any other comments?
I confirmed it fixes the instance described in #165. To reproduce, you can check All-Hands-AI/OpenHands#2728.