Don't let tox install a virtualenv during evaluation #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, `tox` will try to create a virtualenv in which to reinstall all of the dependencies. We don't need this level of isolation for SWE-bench, so use the `tox-current-env` plugin to elide that.
|
Thanks Chris! |
|
Sweet thanks for the catch @waterson! LGTM + merged. Just took a look at an execution log as well and saw the same original behavior. |
sreekarmolakalapalli
pushed a commit
to Modelcode-ai/SWE-bench
that referenced
this pull request
Aug 14, 2024
Don't let tox install a virtualenv during evaluation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default,
toxwill try to create a virtualenv in which to reinstall all of the dependencies. We don't need this level of isolation for SWE-bench, so use thetox-current-envplugin to elide that.Reference Issues/PRs
Fixes #170.
What does this implement/fix? Explain your changes.
Use the
tox-current-envplugin to telltoxnot to try to install its own venv.Any other comments?
🧡 Thanks for contributing!