Pin Jinja2 to version to 3.0.3 for Sphinx #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes swe-bench#241 Pin Jinja2 to version <3.1 for Sphinx in `swebench/harness/constants.py`. * Add `Jinja2<3.1` to the `pip_packages` list for Sphinx in the `SPECS_SPHINX` dictionary. Reference: https://www.ingap.dev/posts/solved-cannot-import-name-environmentfilter-from-jinja2 --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/princeton-nlp/SWE-bench/issues/241?shareId=XXXX-XXXX-XXXX-XXXX).
wistuba
suggested changes
Nov 30, 2024
There was a problem hiding this comment.
This change breaks my build. To reproduce:
python -m swebench.harness.run_evaluation \
--predictions_path gold \
--max_workers 1 \
--dataset_name princeton-nlp/SWE-bench \
--run_id gold_test \
--instance_ids sphinx-doc__sphinx-8595
Using Jinja2==3.0.3 instead works.
SmartManoj
changed the title
wistuba
approved these changes
Dec 1, 2024
|
Sweet, thanks for the fix @SmartManoj @wistuba. Was able to recreate the issue and verify the solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #241
Pin Jinja2 to version <3.1 for Sphinx in
swebench/harness/constants.py.Jinja2<3.1to thepip_packageslist for Sphinx in theSPECS_SPHINXdictionary.Reference: https://www.ingap.dev/posts/solved-cannot-import-name-environmentfilter-from-jinja2
For more details, open the Copilot Workspace session.