Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest): set testURL to localhost #55

Merged
merged 1 commit into from
Jul 28, 2018
Merged

fix(jest): set testURL to localhost #55

merged 1 commit into from
Jul 28, 2018

Conversation

limonte
Copy link
Member

@limonte limonte commented Jul 28, 2018

@coveralls
Copy link

Pull Request Test Coverage Report for Build 400

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.727%

Totals Coverage Status
Change from base Build 309: 0.0%
Covered Lines: 32
Relevant Lines: 32

💛 - Coveralls

@limonte limonte merged commit cbf7792 into master Jul 28, 2018
@limonte limonte deleted the fix/jest-localhost branch July 28, 2018 11:16
zenflow pushed a commit that referenced this pull request Aug 3, 2018
@zenflow
Copy link
Member

zenflow commented Aug 3, 2018

@limonte In master I have removed the release commit and changed the commit message to not use the "fix" commit type.

Yes, the commit "fix"es some problems we're having involving our infrastructure, but it is not a bug fix to the package we're distributing, which is what that commit type is for. Check out the commit types semantic-release understands: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#type

I'm thinking there's no need for a patch release, since the version published would be the exact same as the previious version, with the exception of some development-related parts of package.json (i.e. code would be the exact same).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants