Skip to content
This repository has been archived by the owner on Apr 13, 2021. It is now read-only.

Bring into line with libswiftnav dgnss state refactor #405

Closed
wants to merge 1 commit into from

Conversation

henryhallam
Copy link
Contributor

Untested!

It seems a little disingenuous to initalize the whole dgnss_state only on an as-needed basis when we gain > 4 sats. I'd be inclined to do that in solution_setup() instead. Thoughts?

/cc @fnoble @mookerji

@swiftnav-jenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/piksi_firmware_Pull_Requests/314/
Test PASSed.

@swiftnav-jenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/piksi_firmware_Pull_Requests/315/
Test PASSed.

@mookerji
Copy link
Contributor

I agree. I think the dgnss initialization should happen with a canonical setup.

@henryhallam
Copy link
Contributor Author

retest this please

@fnoble
Copy link
Contributor

fnoble commented May 15, 2015

lgtm (after HITL testing)

@swiftnav-jenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/piksi_firmware_Pull_Requests/316/
Test PASSed.

@denniszollo
Copy link
Contributor

retest this please

@swiftnav-jenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/piksi_firmware_Pull_Requests/317/
Test PASSed.

@henryhallam
Copy link
Contributor Author

Appears to cause hard faults on Piski 1227 in the test rack, but not on Piksi 1757 on my desk...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants