forked from llvm/llvm-project
-
Notifications
You must be signed in to change notification settings - Fork 332
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[FunctionComparator] Differentiate instructions passing different MDS…
…trings (llvm#69543) Prior to this patch, differing metadata operands to two otherwise identical instructions was not enough to consider the instructions different in the eyes of the function comparator. This breaks LLVM virtual function elimination, among other features. In this patch, we handle the case where two associated operands are MDStrings of different value. This patch does not differentiate more complex metadata operands. --------- Co-authored-by: Nuri Amari <[email protected]>
- Loading branch information
Showing
2 changed files
with
73 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
llvm/test/Transforms/MergeFunc/mergefunc-preserve-vfe-intrinsics.ll
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 3 | ||
; RUN: opt -passes=mergefunc -S %s | FileCheck %s | ||
|
||
; This test contains three identical functions, aside from the metadata | ||
; they pass to a function call. This test verifies that the function merger | ||
; pass is able to merge the two functions that are truly identical, | ||
; but the third that passes different metadata is preserved | ||
|
||
declare { ptr, i1 } @llvm.type.checked.load(ptr, i32, metadata) | ||
|
||
define i1 @merge_candidate_a(ptr %ptr, i32 %offset) { | ||
; CHECK-LABEL: define i1 @merge_candidate_a( | ||
; CHECK-SAME: ptr [[PTR:%.*]], i32 [[OFFSET:%.*]]) { | ||
; CHECK-NEXT: [[TMP1:%.*]] = call { ptr, i1 } @llvm.type.checked.load(ptr [[PTR]], i32 [[OFFSET]], metadata !"common_metadata") | ||
; CHECK-NEXT: [[TMP2:%.*]] = extractvalue { ptr, i1 } [[TMP1]], 1 | ||
; CHECK-NEXT: ret i1 [[TMP2]] | ||
; | ||
%1 = call { ptr, i1 } @llvm.type.checked.load(ptr %ptr, i32 %offset, metadata !"common_metadata") | ||
%2 = extractvalue { ptr, i1 } %1, 1 | ||
ret i1 %2 | ||
} | ||
|
||
define i1 @merge_candidate_c(ptr %ptr, i32 %offset) { | ||
; CHECK-LABEL: define i1 @merge_candidate_c( | ||
; CHECK-SAME: ptr [[PTR:%.*]], i32 [[OFFSET:%.*]]) { | ||
; CHECK-NEXT: [[TMP1:%.*]] = call { ptr, i1 } @llvm.type.checked.load(ptr [[PTR]], i32 [[OFFSET]], metadata !"different_metadata") | ||
; CHECK-NEXT: [[TMP2:%.*]] = extractvalue { ptr, i1 } [[TMP1]], 1 | ||
; CHECK-NEXT: ret i1 [[TMP2]] | ||
; | ||
%1 = call { ptr, i1 } @llvm.type.checked.load(ptr %ptr, i32 %offset, metadata !"different_metadata") | ||
%2 = extractvalue { ptr, i1 } %1, 1 | ||
ret i1 %2 | ||
} | ||
|
||
define i1 @merge_candidate_b(ptr %ptr, i32 %offset) { | ||
; CHECK-LABEL: define i1 @merge_candidate_b( | ||
; CHECK-SAME: ptr [[TMP0:%.*]], i32 [[TMP1:%.*]]) { | ||
; CHECK-NEXT: [[TMP3:%.*]] = tail call i1 @merge_candidate_a(ptr [[TMP0]], i32 [[TMP1]]) | ||
; CHECK-NEXT: ret i1 [[TMP3]] | ||
; | ||
%1 = call { ptr, i1 } @llvm.type.checked.load(ptr %ptr, i32 %offset, metadata !"common_metadata") | ||
%2 = extractvalue { ptr, i1 } %1, 1 | ||
ret i1 %2 | ||
} |