Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast forward apple/stable/20190619 to Sep 4. #44

Merged
merged 616 commits into from
Oct 29, 2019
Merged
Changes from 1 commit
Commits
Show all changes
616 commits
Select commit Hold shift + click to select a range
f722a21
[Symbol] Remove redundant include
bulbazord Aug 13, 2019
68dbe57
[lldb][NFC] Add basic IOHandler completion test
Teemperor Aug 13, 2019
d3613e4
[lldb] Reland "Refactor guard variable checks in IRForTarget"
Teemperor Aug 13, 2019
e269c3b
[lldb] Fix Microsoft guard variable detection
Teemperor Aug 13, 2019
2f3a1f9
[Symbol] Decouple clang from CompilerType
bulbazord Aug 13, 2019
468bfaf
[DWARF} Use LLVM's debug line parser in LLDB.
JDevlieghere Aug 13, 2019
94cca43
[DWARF] Guess the path style
JDevlieghere Aug 13, 2019
817f4e8
Initial support for native debugging of x86/x64 Windows processes
aaronsm Aug 13, 2019
dba1cb9
[DebugLine] Be more robust in geussing the path style
JDevlieghere Aug 13, 2019
82436c2
Update Python tests for lldb-server on Windows
aaronsm Aug 14, 2019
90aa1c4
Fix warning: suggest braces around initialization of subobject
JDevlieghere Aug 14, 2019
54904ec
[lldb] Reinstate original guard variable check
Teemperor Aug 14, 2019
d3ea421
[API] Have SBCommandReturnObject::GetOutput/Error return "" instead o…
labath Aug 14, 2019
c8a7a4e
Revert "Minidump/Windows: Fix module lookup"
labath Aug 14, 2019
0fa0455
Add missing SetID method to fix Windows build
aaronsm Aug 14, 2019
4a30ac7
Add missing NativeProcessFactory for lldb-server on Windows
aaronsm Aug 14, 2019
4630270
Revert "[lldb] Reinstate original guard variable check"
Teemperor Aug 14, 2019
b03ee8c
Improve anonymous class heuristic in ClangASTContext::CreateRecordType
shafik Aug 14, 2019
f322109
[NFC] Fix documentation for some utility classes.
JDevlieghere Aug 15, 2019
6a9aa59
Fix variable mismatch between signature and body
JDevlieghere Aug 15, 2019
be91dec
[lldb] Let LLDB depend on intrinsics_gen to fix non-deterministic mod…
Teemperor Aug 15, 2019
37526f2
[lldb][NFC] Refactor remaining completion logic to use CompletionRequ…
Teemperor Aug 15, 2019
fd6596e
Change test to use uint64_t to support compiling for 32-bit architect…
adrian-prantl Aug 15, 2019
86cc602
Stop-hooks weren't getting called on step-out. Fix that.
jimingham Aug 15, 2019
09a0752
[DebugLine] Don't try to guess the path style
JDevlieghere Aug 15, 2019
a7f41cb
[lldb-server] Disable a test on Windows until it can be fixed
aaronsm Aug 16, 2019
5ebe17b
[lldb][NFC] Allow for-ranges on StringList
Teemperor Aug 16, 2019
3e2ff17
[Utility] Reimplement RegularExpression on top of llvm::Regex
JDevlieghere Aug 16, 2019
538a089
Simplify code (NFC).
adrian-prantl Aug 17, 2019
0ba48d2
[lldb][NFC] Remove unused MaterializeInitializer and MaterializeInter…
Teemperor Aug 17, 2019
afb38d5
[CMake] Update CMAKE_OSX_DEPLOYMENT_TARGET to 10.12.
JDevlieghere Aug 18, 2019
f07a6cd
[lldb] Remove unused inheritance in RegularExpression
jankratochvil Aug 19, 2019
5197bdf
[lldb][NFC] Address review comments to StringList for-loop support
Teemperor Aug 19, 2019
ef68dec
[lldb][NFC] Use GetMaxStringLength in CommandObjectApropos::DoExecute
Teemperor Aug 19, 2019
faa1eb9
[lldb][NFC] Remove StringList::AutoComplete
Teemperor Aug 19, 2019
4a77e36
[lldb][NFC] Add a few more completion tests to increase test coverage
Teemperor Aug 19, 2019
daef54d
[lldb][NFC] Use CompletionRequest in Variable::AutoComplete
Teemperor Aug 19, 2019
24f7d02
[lldb][NFC] Stop using GetNumberOfMatches in CompletionRequest test
Teemperor Aug 19, 2019
e5b5dea
[dotest] Add --dwarf-version to override the tested DWARF version.
JDevlieghere Aug 19, 2019
56e607d
[lldb] Make TestIOHandlerCompletion more stable and document it
Teemperor Aug 19, 2019
bf994ec
[lldb-vscode] add `launchCommands` to handle launch specific commands
bulbazord Aug 19, 2019
04c556d
Fix use-after-free
mgehre Aug 19, 2019
6571196
Windows: Include "windows" Instead of "Windows"
compnerd Aug 19, 2019
d8b3b3a
[lldb] Fix typo on the BreakpointLocation header and the lldbtest.py …
medismailben Aug 19, 2019
4a4a258
[lldb] D66174 `RegularExpression` cleanup
jankratochvil Aug 20, 2019
365d685
[lldb][NFC] Test quotes when completing
Teemperor Aug 20, 2019
c57dbe1
[cmake] Remove the test for libstdc++<4.9
labath Aug 20, 2019
e3c86ee
unittests: Use yaml2obj as a library instead of an external process
labath Aug 20, 2019
e51c7ad
Convert minidump unittests to use llvm::yaml::convertYAML
labath Aug 20, 2019
90f9182
Fix build for r369374
labath Aug 20, 2019
009aaa3
[lldb] Use the new Regex::isValid() with no parameter
jankratochvil Aug 20, 2019
9474b96
Make the FindTypes(std::vector<CompilerContext>, ...) API testable in…
adrian-prantl Aug 20, 2019
28332b1
[ClangExpressionParser] Add ClangDeclVendor
bulbazord Aug 20, 2019
cc103a6
[CMake] Remove LLDB_TEST_USE_CUSTOM_C(XX)_COMPILER
JDevlieghere Aug 20, 2019
3cc3664
[Symbol][NFC] Remove references to clang in TypeMap
bulbazord Aug 20, 2019
626f26c
[NFC] Update RegularExpression documentation
JDevlieghere Aug 20, 2019
fc7d2ce
[LLDB][Test] Remove `skipIfWindows` for conditional breakpoint test (…
medismailben Aug 20, 2019
ca082af
[Symbol] Move VerifyDecl to ClangASTContext
bulbazord Aug 20, 2019
cc4ea72
[NFC] Fix -Wdocumentation warnings in Utility.
JDevlieghere Aug 20, 2019
1cd9df8
[dotest] Don't set the DWARF version override in CFLAGS_EXTRA.
JDevlieghere Aug 20, 2019
fa70b50
[Doxygen] Document private class members.
JDevlieghere Aug 21, 2019
e550738
Update a few tests that may change the platform to save & restore
jasonmolenda Aug 21, 2019
3c9bbd8
[NFC] Remove lldb_utility namespace.
JDevlieghere Aug 21, 2019
40803bd
[NFC] Simplify code
JDevlieghere Aug 21, 2019
7edc413
[NFC] Remove unused function GetHexWithFixedSize
JDevlieghere Aug 21, 2019
38f3f79
[Symbol] Remove unused clang headers from Type
bulbazord Aug 21, 2019
fee719f
Properly EXCLUDE_FROM_ALL the testing support library
labath Aug 21, 2019
8b7b09c
Fix an unused variable warning in ClangASTContext.cpp
labath Aug 21, 2019
72d2e32
[lldb][NFC] Add tests for invalid command invocations
Teemperor Aug 21, 2019
3085eb6
[lldb][NFC] Add tests for register command
Teemperor Aug 21, 2019
e9e12c4
[lldb] Add tests for setting completions and enable 'settings remove'…
Teemperor Aug 21, 2019
5bddc69
Fix two compiler warnings
labath Aug 21, 2019
c8c959e
Recommit "Minidump/Windows: Fix module lookup""
labath Aug 21, 2019
1e85457
[lldb] Add tests for 'settings remove' and fix error message typos
Teemperor Aug 21, 2019
83aa4fd
[lldb][NFC] Merge multiple TestApropos.py
Teemperor Aug 21, 2019
2d17aa8
Generalize FindTypes with CompilerContext to support fuzzy lookup
adrian-prantl Aug 21, 2019
57e3bf5
Add char8_t support (C++20)
JDevlieghere Aug 21, 2019
d53a08d
When building file without debug info, include the architecture
jasonmolenda Aug 21, 2019
6236c60
[test] Update test so it matches the Windows output
JDevlieghere Aug 21, 2019
d65a233
The g_format_infos table needs to be updated in concert with the
jasonmolenda Aug 22, 2019
9c8a1fb
[FormatManager] Add static_assert to keep formats in sync.
JDevlieghere Aug 22, 2019
84bce02
[FormatManage] Fix the format info order
JDevlieghere Aug 22, 2019
c679e3a
[lldb] Replace std::once_flag with llvm::once_flag.
dcci Aug 22, 2019
fda6823
[debugserver] Switch back to std::once_flag
JDevlieghere Aug 22, 2019
567d6bb
[lldb][NFC] Remove WordComplete mode, make result array indexed from …
Teemperor Aug 22, 2019
cd73e1c
[lldb][NFC] Remove dead code that is supposed to handle invalid comma…
Teemperor Aug 22, 2019
d20c274
[lldb][NFC] NFC cleanup for the completion code
Teemperor Aug 22, 2019
bddb4c5
[lldb][NFC] Remove unused return value from HandleOptionArgumentCompl…
Teemperor Aug 22, 2019
69fb300
[lldb][NFC] Add test for target stop-hook disable/enable/delete
Teemperor Aug 22, 2019
705281b
[lldb][NFC] Fix indentation in CommandObjectProcess
Teemperor Aug 22, 2019
cf48662
[lldb] Fix `TestDataFormatterStdList` regression
jankratochvil Aug 22, 2019
6044256
[lldb] Remove ')' to fix the build
Teemperor Aug 22, 2019
fcc2ae2
Doxygenify comments.
adrian-prantl Aug 22, 2019
e14fafa
Remove redundant curly braces.
adrian-prantl Aug 22, 2019
af27ae6
[heap.py] Add missing declaration for malloc_get_all_zones
vedantk Aug 22, 2019
dbb347f
Extend FindTypes with CompilerContext to allow filtering by language.
adrian-prantl Aug 22, 2019
fe61870
Add missing include
adrian-prantl Aug 22, 2019
d8567fe
Add missing include
adrian-prantl Aug 22, 2019
cc22fd3
Rename lldb/source/Interpreter/OptionValueFileSpecLIst.cpp to
adrian-prantl Aug 22, 2019
6ca0ce4
Rename lldb/source/Interpreter/OptionValueFileSpecListTmp.cpp to
adrian-prantl Aug 22, 2019
9a1bf39
Revert Extend FindTypes with CompilerContext to allow filtering by la…
adrian-prantl Aug 22, 2019
7c83648
Revert [heap.py] Add missing declaration for malloc_get_all_zones
vedantk Aug 22, 2019
e741ac2
TestAppleSimulatorOSType: Pass the --standalone argument to simctl
fredriss Aug 22, 2019
390ac9d
Extend FindTypes with CompilerContext to allow filtering by language.
adrian-prantl Aug 22, 2019
1cb236a
Add missing dot.
adrian-prantl Aug 22, 2019
f8a78a8
[LLDB] Address post-commit code review feedback.
JDevlieghere Aug 23, 2019
6f05587
[Symbol] Decouple clang from DeclVendor
bulbazord Aug 23, 2019
1be3249
Windows: explicitly cast constants to `DWORD`
compnerd Aug 23, 2019
0cc3264
Upstream support for macCatalyst Mach-O binaries.
adrian-prantl Aug 23, 2019
7424a57
Skip tail call frame tests when dwarf_version < 4
vedantk Aug 23, 2019
a5ce9f6
[NFC] Fix comments and formatting.
JDevlieghere Aug 23, 2019
f0e9e27
[lldb][NFC] Add ProcessInfo::GetNameAsStringRef to simplify some code
Teemperor Aug 26, 2019
a74bb01
[lldb] Construct the dummy target when the first Debugger object is c…
Teemperor Aug 26, 2019
68ede21
Breakpad: Add support for parsing STACK WIN records
labath Aug 26, 2019
8c13999
Postfix: move more code out of the PDB plugin
labath Aug 26, 2019
14d606d
Fix a type mismatch error in GDBRemoteCommunicationServerCommon
labath Aug 26, 2019
016c782
Fix windows build after r369894
labath Aug 26, 2019
1e78a5b
ProcessInstanceInfo: Fix dumping of invalid user ids
labath Aug 26, 2019
3319ab0
Move ProcessInstanceInfoTest to Utility
labath Aug 26, 2019
7ad6710
[ProcessWindows] Remove equivalent macros
tkrasnukha Aug 26, 2019
0d0cb79
Really fix the type mismatch error in GDBRemoteCommunicationServerCommon
labath Aug 26, 2019
7eb3325
[dotest] Print invocation when encountering an error.
JDevlieghere Aug 26, 2019
f15e4ca
TestFunctionStarts.py: add synchronization
fredriss Aug 26, 2019
0bf2af9
[lldb][NFC] Remove dead code that handles situations where LLDB has n…
Teemperor Aug 26, 2019
88cbcbf
[Core] GetAPInt should return an Optional
bulbazord Aug 26, 2019
10717b3
[build_exception] Decode build failure messages
vedantk Aug 26, 2019
1c8888d
Send error message on failed attach from debugerserver.
jasonmolenda Aug 27, 2019
94c97cc
[dotest] Remove long running test "decorator" and re-enable tests.
JDevlieghere Aug 27, 2019
c402093
[ConnectionFileDescriptor] Add shutdown check in ::Write.
JDevlieghere Aug 27, 2019
1d2ef8a
[test] Disable two of the recently (re)enabled tests on Windows.
JDevlieghere Aug 27, 2019
a735ca0
CommandObjectExpression: Fix a misleading-indentation warning
labath Aug 27, 2019
8d0b1ff
Fix TestStdCXXDisassembly.py
labath Aug 27, 2019
6055a25
Fix an unused variable warning in no-assert builds
labath Aug 27, 2019
218607e
DWARFExpression: Simplify class interface
labath Aug 27, 2019
9828b33
[lldb] Allow partial completions to fix directory completion.
Teemperor Aug 27, 2019
87cb94f
[ASTImporter] Fix name conflict handling with different strategies
Aug 27, 2019
eb9561b
[lldb][NFC] Give added test method a unique name
Teemperor Aug 27, 2019
d8c912a
[lldb][NFC] Add some tests for the target subcommands
Teemperor Aug 27, 2019
06e486f
Stabilize TestIOHandlerCompletion
labath Aug 27, 2019
210ef04
[lldb][NFC] Add missing invalid_core_file to TestTargetCommand test
Teemperor Aug 27, 2019
b11031a
[lldb] Fix x86 compilation
tkrasnukha Aug 27, 2019
45ceb83
[dotest] Remove results port
JDevlieghere Aug 27, 2019
16126fc
[Platform/Android] Read the adb server from an env variable if set
lanza Aug 27, 2019
ac3426d
[dotest] Remove check for LLDB_TESTSUITE_FORCE_FINISH
JDevlieghere Aug 27, 2019
b4827f9
Revert "[lldb] Move redundant persistent variable counter to ClangPer…
adrian-prantl Aug 27, 2019
ca807ba
[lit] Don't set DYLD_LIBRARY_PATH when DYLD_INSERT_LIBRARIES is set.
JDevlieghere Aug 28, 2019
99f60b3
[test] Disable TestConcurrentManySignals on Darwin.
JDevlieghere Aug 28, 2019
47346d4
[lit] Fix the way we check if an environment var is set
JDevlieghere Aug 28, 2019
ab346d3
Update name of objc runtime SPI function we call for class names.
jasonmolenda Aug 28, 2019
58eb184
[lldb][NFC] Update documentation of Handle[Argument]Completion
Teemperor Aug 28, 2019
c03413b
[lldb][NFC] Get rid of C-strings in HandleOptionCompletion
Teemperor Aug 28, 2019
b527f36
[lldb] Fix and test completion for ambiguous long options
Teemperor Aug 28, 2019
92aea10
[lldb][NFC] Test custom C++ operators
Teemperor Aug 28, 2019
9f7f9d7
[lldb][NFC] Extend operator test case with conversion operators
Teemperor Aug 28, 2019
99dd734
[lldb][NFC] Actually run all expects in lang/cpp/operators
Teemperor Aug 28, 2019
b33ab50
[lldb][NFC] Test named operators like new and function names that mig…
Teemperor Aug 28, 2019
3720989
[lldb][NFC] Refactor and document ClangASTContext::IsOperator
Teemperor Aug 28, 2019
2bd4dbe
[dotest] Remove -q (quiet) flag.
JDevlieghere Aug 28, 2019
1b3f23c
[TestCppOperators] Enable TestCppOperators on Windows.
JDevlieghere Aug 28, 2019
7ddbe8c
[dotest] Don't spend time replacing spaces in print output.
JDevlieghere Aug 28, 2019
549c71b
[dotest] Don't try to guess the llvm binary dir.
JDevlieghere Aug 28, 2019
672a259
[dotest] Don't try to guess the lldb binary & python dir.
JDevlieghere Aug 28, 2019
d0ce454
[dotest] Remove outdates TODO
JDevlieghere Aug 28, 2019
97f71cc
[test] Temporarily disable two tests on Windows
JDevlieghere Aug 28, 2019
1503a03
[Core] Use GetAPInt instead of constructing APInts in place
bulbazord Aug 28, 2019
170ed09
[dotest] Centralize and simplify session dir logic (NFC)
JDevlieghere Aug 28, 2019
c06be40
[dotest] Remove --rerun-max-file-threshold
JDevlieghere Aug 28, 2019
ac78ab4
[dotest] Remove --event-add-entries
JDevlieghere Aug 28, 2019
1b79067
[dotest] Make dotest.py invocation repeatable
JDevlieghere Aug 28, 2019
40be0ad
[TSanRuntime] Upstream thread swift race detector.
dcci Aug 29, 2019
bf14539
[python] remove testsuite vestiges.
dcci Aug 29, 2019
8f6ad9c
Provide a real link to the doc and remove old information
sylvestre Aug 29, 2019
65be65b
fix the bugzilla url
sylvestre Aug 29, 2019
04b4bcb
use https for llvm.org in the doc
sylvestre Aug 29, 2019
ecf09aa
[lldb][NFC] Also test operator new/new[]/delete/delete[]/comma/addr-of
Teemperor Aug 29, 2019
889f68f
[lldb][NFC] Try fixing TestCompletion.py on Windows
Teemperor Aug 29, 2019
eae58fa
Remove DWARFExpression::LocationListSize
labath Aug 29, 2019
90b5843
Fix GetDIEForDeclContext so it only returns entries matching the prov…
labath Aug 29, 2019
90f9502
Revert "[TSanRuntime] Upstream thread swift race detector."
dcci Aug 29, 2019
b176a00
[dotest] Remove the curses result formatter.
JDevlieghere Aug 29, 2019
8c7ea52
[dotest] Remove deprecated loggin through env variables.
JDevlieghere Aug 29, 2019
d681d7b
[test] Fix various module cache bugs and inconsistencies
JDevlieghere Aug 29, 2019
7877190
[lldb][NFC] Document options parameter in ClangUserExpression constru…
Teemperor Aug 29, 2019
06b0a3e
[lit] Print exit code in for unresolved (lldb)tests.
JDevlieghere Aug 29, 2019
95d2567
[lldb][NFC] Move Clang-specific flags to ClangUserExpression
Teemperor Aug 30, 2019
de43f8c
dotest: improvements to the pexpect tests
labath Aug 30, 2019
878aeb4
[dotest] Finish removing -q
labath Aug 30, 2019
033c94c
[lit] Fix my earlier bogus fix to not set DYLD_LIBRARY_PATH with Asan.
JDevlieghere Aug 30, 2019
63d8e07
[lldb][NFC] More tests for invalid register command invocations
Teemperor Aug 30, 2019
1b9bac6
[test] Make sure PROMPT is a string
JDevlieghere Aug 30, 2019
f39d564
[test] Fix 'argument must be str, not bytes' for Python 3.
JDevlieghere Aug 30, 2019
123c021
[lit] Only set DYLD_LIBRARY_PATH for shared builds
JDevlieghere Aug 30, 2019
8af95e9
[test] Make sys.stdout compatible with both Python 2 & 3
JDevlieghere Aug 30, 2019
caeaac2
[lldb][NFC] Remove unused prompt variable in TestMultilineCompletion.py
Teemperor Aug 31, 2019
b4c3a06
[lldb] Unify target checking in CommandObject
Teemperor Aug 31, 2019
d0e841c
[lldb] Restructure test folders to match LLDB command hierarchy
Teemperor Sep 1, 2019
4e77441
[lldb][NFC] Fix failing tests after restructuring test folder
Teemperor Sep 1, 2019
f5e74bd
[lldb] Small optimization of FormatMap::Delete
jankratochvil Sep 1, 2019
9a6f768
[lldb][NFC] Fix failing tests on macOS after restructuring test folder
Teemperor Sep 1, 2019
a4dce64
[lldb][NFC] Add test for invalid expression command args
Teemperor Sep 1, 2019
9040323
[lldb] Test and fix invalid log command invocations
Teemperor Sep 1, 2019
eff185e
[lldb][NFC] Remove unnecessary lldb_enable_attach in TestMultilineCom…
Teemperor Sep 2, 2019
a34324d
[lldb][NFC] Add basic test for GUI command
Teemperor Sep 2, 2019
cc106fe
[lldb] Add description to option completions.
Teemperor Sep 2, 2019
53a9b73
[lldb][NFC] Add test for source info
Teemperor Sep 2, 2019
479998e
[lldb][NFC] Remove unused imports from TestIntegerTypes.py
Teemperor Sep 2, 2019
0221f81
[ARM64] Simplify RegisterInfos_arm64.h with macro based RegisterInfo …
omjavaid Sep 2, 2019
2572504
[lldb][NFC] Remove unused imports from TestIntegerTypesExpr.py
Teemperor Sep 2, 2019
1b21fe2
[lldb][NFC] Add test for invalid gui command
Teemperor Sep 2, 2019
2cc1673
NativeProcessLinux: Remove some register context boilerplate
labath Sep 2, 2019
de5e092
[dotest] Add @skipIfCursesSupportMissing and annotate the new gui test
labath Sep 2, 2019
a5d9650
[lldb][NFC] Remove setup boilerplate from types/ tests
Teemperor Sep 3, 2019
3a65977
[lldb][NFC] Unify log files in commands/log/basic
Teemperor Sep 3, 2019
c1bc6f5
[lldb] Test 'command' commands and fix the found crashes
Teemperor Sep 3, 2019
3dfc23a
[lldb][NFC] Also test unaliasing in nested_alias test
Teemperor Sep 3, 2019
8aea4fd
[lldb][NFC] Simplify script_alias test
Teemperor Sep 3, 2019
d90b2be
[lldb][NFC] Remove unnecessary constructors from invalid-args tests
Teemperor Sep 3, 2019
5ffc7df
[lldb][NFC] Test that enabling all log options doesn't crash anything
Teemperor Sep 3, 2019
5029e3c
[lldb][NFC] Test 'command delete'
Teemperor Sep 3, 2019
0034d43
[lldb] Test 'frame select -r' and fix that INT32_MIN breaks the optio…
Teemperor Sep 3, 2019
4e48878
[lldb] Replace std::call_once() with llvm::call_once()
mgorny Sep 3, 2019
5cd0107
[lldb][NFC] Disable added frame select and all log option test on win…
Teemperor Sep 3, 2019
8ec083c
[test] Remove print statements and verify that the symbol exists
JDevlieghere Sep 3, 2019
08ba252
[test] Addres TestConcurrentMany*.py flakiness on macOS
JDevlieghere Sep 3, 2019
ed836f7
[lldb][NFC] Remove unused overload of File::Read
Teemperor Sep 3, 2019
4bb16c9
[lldb][NFC] Remove lldbcurses.py
Teemperor Sep 3, 2019
835fd46
[Driver] Remove duplicate option parsing (NFC)
JDevlieghere Sep 3, 2019
1ef1455
[lldb] [test] Un-mark two commands/register tests XFAIL
mgorny Sep 4, 2019
6f73824
[lldb] [test] Mark 'reenabled' tests XFAIL on NetBSD
mgorny Sep 4, 2019
2934308
[dotest] Avoid the need for LEVEL= makefile boilerplate
labath Sep 4, 2019
f6200ca
[lldb][NFC] Add a simple test for thread_local storage.
Teemperor Sep 4, 2019
4c445f6
[lldb][NFC] Remove WriteRegister copy-pasta from ObjectFileMachO
Teemperor Sep 4, 2019
8754a64
[lldb][NFC] Rename ReadRegisterValue to PrintRegisterValue
Teemperor Sep 4, 2019
3cc02ea
Port TestBatchMode to PExpectTest class
labath Sep 4, 2019
c5431be
Code cleanup: Change FormattersContainer::KeyType from SP to rvalue
jankratochvil Sep 4, 2019
c790f1f
[lldb] Early exit in RangeDataVector:FindEntryIndexesThatContain
Teemperor Sep 4, 2019
885aad7
[lldb] Limit the amount of zeroes we use for padding when printing sm…
Teemperor Sep 4, 2019
ca4dee6
[lldb] Fix log statement in Socket::Write
Teemperor Sep 4, 2019
a9c2e92
disassemble command: fix error message when disassembly fails
labath Sep 4, 2019
dc92fa8
Workaround TestConcurrentMany* flakiness in a more pricipled way
fredriss Sep 4, 2019
fb26d36
Upstream macCatalyst support in debugserver and the macOS dynamic loader
adrian-prantl Sep 4, 2019
92121e7
[Python] Fix whitespace before making changes (NFC)
JDevlieghere Sep 4, 2019
5fad792
[Python] Implement truth testing for lldb.value
JDevlieghere Sep 4, 2019
a5ffceb
[Python] Implement __next__ for value_iter
JDevlieghere Sep 4, 2019
23142ce
Revert "[test] Address TestConcurrentMany*.py flakiness on macOS"
JDevlieghere Sep 4, 2019
eb845cb
[test] Escape path to match the literal string
JDevlieghere Sep 4, 2019
65b7243
[Disassembler] Simplify a few methods (NFC)
JDevlieghere Sep 4, 2019
6b16cd3
[Disassembler] Simplify a few methods (2/2) (NFC)
JDevlieghere Sep 4, 2019
1f9a3df
[dotest] Delete trivial inline test makefiles
labath Sep 5, 2019
00ca90d
[CMake] Always build debugserver on Darwin and allow tests to use the…
weliveindetail Jul 18, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[DebugLine] Be more robust in geussing the path style
My previous change didn't fix the Windows bot. This patch is an attempt
to make guessing the path style more robust by first looking at the
compile dir and falling back to the actual file if that's unsuccessful.

llvm-svn: 368772
(cherry picked from commit 3cb3aa2)
  • Loading branch information
JDevlieghere authored and adrian-prantl committed Oct 28, 2019
commit dba1cb9ee814a3864517647b4d274efe49c1b59f
12 changes: 9 additions & 3 deletions lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
Original file line number Diff line number Diff line change
@@ -186,6 +186,8 @@ ParseSupportFilesFromPrologue(const lldb::ModuleSP &module,
FileSpecList support_files;
support_files.Append(first_file);

llvm::Optional<FileSpec::Style> compile_dir_style =
FileSpec::GuessPathStyle(compile_dir);
const size_t number_of_files = prologue.FileNames.size();
for (size_t idx = 1; idx <= number_of_files; ++idx) {
std::string original_file;
@@ -198,9 +200,13 @@ ParseSupportFilesFromPrologue(const lldb::ModuleSP &module,
continue;
}

auto maybe_path_style = FileSpec::GuessPathStyle(original_file);
FileSpec::Style style =
maybe_path_style ? *maybe_path_style : FileSpec::Style::native;
FileSpec::Style style = FileSpec::Style::native;
if (compile_dir_style) {
style = *compile_dir_style;
} else if (llvm::Optional<FileSpec::Style> file_style =
FileSpec::GuessPathStyle(original_file)) {
style = *file_style;
}

std::string remapped_file;
if (!prologue.getFileNameByIndex(