-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable hierarchy-based link resolver implementation by default #498
Merged
d-ronnqvist
merged 5 commits into
swiftlang:main
from
d-ronnqvist:enable-link-resolver-feature
Mar 10, 2023
Merged
Enable hierarchy-based link resolver implementation by default #498
d-ronnqvist
merged 5 commits into
swiftlang:main
from
d-ronnqvist:enable-link-resolver-feature
Mar 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my local benchmarking the new resolver is 2-3% faster (not just link resolution but the full build) at the cost of ~1.5% memory usage.
|
@swift-ci please test |
franklinsch
approved these changes
Mar 10, 2023
1 task
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: rdar://98692937
Summary
This enabled the hierarchy-based link resolver by default. It also updates a handful of symbol links to remove disambiguation that's now redundant.
Dependencies
None
Testing
defaults remove -g DocCUseHierarchyBasedLinkResolver
swift run docc convert ./Tests/SwiftDocCTests/Test\ Bundles/TestBundle.docc
You should see error messages from the new link resolver—meaning that the feature is enabled by default—for example:
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
[ ] Added tests./bin/test
script and it succeeded[ ] Updated documentation if necessary