Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable Doxygen support by default #519

Merged
merged 2 commits into from
Mar 26, 2023

Conversation

QuietMisdreavus
Copy link
Contributor

Bug/issue #, if applicable: rdar://107002535

Summary

This PR turns on the Doxygen support added in #497 for all doc builds.

Dependencies

None

Testing

See test instructions in #497. Also ensure that existing functionality is not impacted.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • [ n/a ] Added tests
  • Ran the ./bin/test script and it succeeded
  • [ n/a ] Updated documentation if necessary

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

@d-ronnqvist
Copy link
Contributor

Should it still be possible to disable the Doxygen support by passing --no-experimental-parse-doxygen-commands?

@QuietMisdreavus
Copy link
Contributor Author

@d-ronnqvist I thought about allowing it, but decided against it. I can see how it would be useful for debugging; i'll try to work it in.

@ethan-kusters
Copy link
Contributor

Should it still be possible to disable the Doxygen support by passing --no-experimental-parse-doxygen-commands?

I don't think this should be possible at this level actually. At some point we might want to add support for different parsing modes (disabling legacy Swift callout support and Doxygen support for example) but I would view that as a separate feature and not something we would do through the global Features struct.

@d-ronnqvist
Copy link
Contributor

@swift-ci please test

@d-ronnqvist d-ronnqvist merged commit 2e4d3c5 into swiftlang:main Mar 26, 2023
@QuietMisdreavus QuietMisdreavus deleted the doxygen-default branch March 27, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants