[5.9] Better support for relative links when multiple symbols in the hierarchy have the same name #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
d-ronnqvist
commented
May 5, 2023
d-ronnqvist
commented
- Explanation: Better support for resolving symbol links when multiple symbols in the hierarchy (incl. the module symbol) have the same name. The original PR has detailed examples.
- Scope: Link resolution for local symbol links and documentation links.
- Issue: rdar://76252171&108672152
- Risk: Low. Changes to link resolution has broad impact but are also very well tested.
- Testing: New tests verify that links that previously failed now succeed, that still failing links have the same error messages, and that the previous regression that led to a revert isn't reintroduced by this. I also manually tested the project where that regression previously occurred.
- Original PR: Better support for relative links when multiple symbols in the hierarchy have the same name #578
- Reviewers: @daniel-grumberg
…chy have the same name (swiftlang#578) * Walk up the path hierarchy if links fail to resolve in a specific scope rdar://108672152 Also, check the module's scope if the link couldn't otherwise resolve rdar://76252171 * Fix test linking to heading that doesn't exist * Update expression that was very slow to type check * Fix warning about mutating a captured sendable value * Remove outdated comment about adding more test assertions * Update test for old link resolver implementation
|
@swift-ci please test |
franklinsch
approved these changes
May 9, 2023
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.