Make visitLineBreak return new line instead of space #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 18, 2023
|
@swift-ci please test |
d-ronnqvist
reviewed
Jun 21, 2023
Kyle-Ye
force-pushed
the
bugfix/kyle/hardbreak
branch
from
b4ff394 to
59d1f6f
Compare
d-ronnqvist
approved these changes
Jun 26, 2023
Kyle-Ye
force-pushed
the
bugfix/kyle/hardbreak
branch
from
59d1f6f to
16b212e
Compare
|
@swift-ci please test |
3 tasks
Kyle-Ye
added a commit
to Kyle-Ye/swift-docc
that referenced
this pull request
Jul 11, 2023
* Make visitLineBreak return new line instead of space * Update test case for more human-readable
d-ronnqvist
pushed a commit
that referenced
this pull request
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable:
With the corresponding swift-docc-render PR, Close #477.
Summary
Make visitLineBreak return new line instead of space to align with CommonMark spec
Dependencies
Testing
Update RenderContentCompilerTests.swift
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded