Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cxx-interop] make -emit-clang-header-path a driver flag #1371

Merged
merged 1 commit into from
Jun 8, 2023
Merged

[cxx-interop] make -emit-clang-header-path a driver flag #1371

merged 1 commit into from
Jun 8, 2023

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Jun 7, 2023

No description provided.

@hyp hyp requested a review from artemcm June 7, 2023 18:26
@hyp
Copy link
Contributor Author

hyp commented Jun 7, 2023

swiftlang/swift#66418

@swift-ci please test

@hyp hyp mentioned this pull request Jun 7, 2023
Merged
@artemcm
Copy link
Contributor

artemcm commented Jun 7, 2023

@hyp, just to sanity check, was Options.swift generated using the automation described in:
https://github.com/apple/swift-driver#rebuilding-optionsswift
?

@hyp
Copy link
Contributor Author

hyp commented Jun 7, 2023

@artemcm yes. I had to add only the relevant change, it looks like there were other changes that were made by that tool.

@hyp hyp merged commit 79a9365 into swiftlang:main Jun 8, 2023
@hyp hyp mentioned this pull request Jun 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemcm artemcm artemcm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyp @artemcm