Proposal for Keypath #644
Merged
Proposal for Keypath #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjmanton
reviewed
Mar 17, 2017
proposals/XXXX-key-paths.md
Outdated
|
|
||
| let firstFriendsNameKeyPath = Person.friends[0].name | ||
|
|
||
| let firstFriend = luke[path] // han |
There was a problem hiding this comment.
Should this be let firstFriend = luke[firstFriendsNameKeyPath] ?
There was a problem hiding this comment.
Yes it should. That was a Last Minute Change™ where the find-replace failed. :(
- fix example so that it compiles - move to #keyPath syntax - add a parameter label for the subscripts - various prose tweaks to account for the above
|
You have this:
Does this not conflict with backward compatibility?
|
|
This, along with other spelling matters regarding of this is being discussed on the swift-evolution list.
…-Michael
On Mar 31, 2017, at 4:07 AM, Denis Bredelet ***@***.***> wrote:
You have this:
// or equivalently, with type inferred from context
luke[keyPath: #keyPath(.friends[0].name)]
Does this not conflict with backward compatibility?
There is no change or interaction with the #keyPath() syntax introduced in Swift 3. #keyPath(Person.bestFriend.name) will still produce a String
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#644 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/APaPv1iV-aWMV4UOYnSvpQcDnpjfNuQWks5rrN5sgaJpZM4Mg2Rx>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.