Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @testable imports WIP #8145

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Conversation

MaxDesiatov
Copy link
Contributor

[One line description of your change]

Motivation:

[Explain here the context, and why you're making that change. What is the problem you're trying to solve.]

Modifications:

[Describe the modifications you've done.]

Result:

[After your change, what will change.]

@MaxDesiatov MaxDesiatov changed the title Remove @testable imports WIP Remove @testable imports WIP Nov 28, 2024
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

2 similar comments
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test windows

@rauhul
Copy link
Member

rauhul commented Nov 30, 2024

Sorry for the negative feedback, but this seems like a really bad idea. it opens all of these APIs to be used by anything in package for the (imo small) benefit of avoiding @testable. instead please consider @_spi(Test) or something similar like swift-driver does. It's a lot more clear at the declaration site why the API is public than package.

@MaxDesiatov
Copy link
Contributor Author

MaxDesiatov commented Dec 1, 2024

This PR is a draft WIP and isn't ready for feedback.

I'm only trying it out to see if this enables incremental builds for bootstrap builds at all via any changes in code, which may not be the case in the end. At that point we won't care if @_spi is better (IMO it isn't because of its excess verbosity and lack of support in tooling like auto-completion) than package if neither solve the actual problem.

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test linux

@MaxDesiatov MaxDesiatov force-pushed the maxd/remove-testable-imports branch from 678769d to f919e2c Compare December 2, 2024 11:32
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants