Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[swift-4.1-branch][stdlib] Introduce compactMap and deprecate one flatMap variant #13807

Merged
merged 1 commit into from
Jan 9, 2018
Merged

[swift-4.1-branch][stdlib] Introduce compactMap and deprecate one flatMap variant #13807

merged 1 commit into from
Jan 9, 2018

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented Jan 8, 2018

  • Explanation: Implements SE-0187: deprecate one variant of flatMap, and provide the same functionality as compactMap.
  • Risk: Deprecated overloads make this change source compatible, compactMap is an addition.
  • Reviewed By: Ben Cohen
  • Testing: Automated test suite with extra cases
  • Directions for QA: N/A
  • Radar: rdar://problem/34918180

[stdlib] Introduce compactMap and deprecate one flatMap variant
d19f9fa 
This is the implementation of
[SE-0187](https://github.com/apple/swift-evolution/blob/master/proposals/0187-introduce-filtermap.md)

<rdar://problem/34918180>

Cherrypicked and squashed from the following commits:
6f7aecd fb49b3e 8ec6c45 96d3439 128092a
@moiseev
Copy link
Contributor Author

moiseev commented Jan 8, 2018

@swift-ci Please test

@moiseev
Copy link
Contributor Author

moiseev commented Jan 8, 2018

/cc @aciidb0mb3r

@moiseev
Copy link
Contributor Author

moiseev commented Jan 8, 2018

@swift-ci Please nominate

@aciidgh
Copy link
Contributor

aciidgh commented Jan 8, 2018

Thanks!

@moiseev
Copy link
Contributor Author

moiseev commented Jan 8, 2018

Cherry picked from #12819

@moiseev
Copy link
Contributor Author

moiseev commented Jan 8, 2018

@swift-ci Please Test Source Compatibility

@moiseev moiseev mentioned this pull request Jan 8, 2018
Merged
@airspeedswift airspeedswift merged commit c167720 into swiftlang:swift-4.1-branch Jan 9, 2018
@moiseev moiseev deleted the compactmap-4 branch January 9, 2018 00:55
benrimmington added a commit to swiftlang/swift-evolution that referenced this pull request Jan 9, 2018
@benrimmington
[SE-0187] Change to "Implemented (Swift 4.1)"
3531c2d 
<swiftlang/swift#13807>
johnno1962 pushed a commit to DoubleSpeak/swift-evolution that referenced this pull request Mar 18, 2018
@benrimmington @johnno1962
[SE-0187] Change to "Implemented (Swift 4.1)"
e4053ce 
<swiftlang/swift#13807>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moiseev @aciidgh @airspeedswift