Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude properties of class with type Self [5.1] #23613

Merged
merged 5 commits into from
Apr 2, 2019
Merged

Exclude properties of class with type Self [5.1] #23613

merged 5 commits into from
Apr 2, 2019

Conversation

slavapestov
Copy link
Contributor

@slavapestov slavapestov commented Mar 27, 2019 •
edited
Loading

Cherry-picking @johnno1962's PR #23485 to the 5.1 branch.

@slavapestov slavapestov changed the base branch from master to swift-5.1-branch March 27, 2019 22:56
@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@slavapestov slavapestov mentioned this pull request Mar 27, 2019
Merged
@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

@johnno1962
Copy link
Contributor

johnno1962 commented Mar 28, 2019 •
edited
Loading

:( I've looked at the compatibility failures and it's not clear they are Self related (many are SPM v3 manifest version deprecations). Is it too late to run the compatibility checks on master branch?

@slavapestov
Copy link
Contributor Author

The failures are not related.

@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@slavapestov slavapestov merged commit 779cf83 into swiftlang:swift-5.1-branch Apr 2, 2019
@johnno1962
Copy link
Contributor

Thanks @slavapestov

@johnno1962 johnno1962 mentioned this pull request Apr 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slavapestov @johnno1962