Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeChecker: consolidate func & subscript signature validation #24151

Merged
merged 1 commit into from
Apr 21, 2019
Merged

TypeChecker: consolidate func & subscript signature validation #24151

merged 1 commit into from
Apr 21, 2019

Conversation

AnthonyLatsis
Copy link
Collaborator

@AnthonyLatsis
Copy link
Collaborator Author

Let me see if I can resolve this without a clean build..

@slavapestov
Copy link
Contributor

@swift-ci Please smoke test

@slavapestov
Copy link
Contributor

@swift-ci Please test source compatibility

@AnthonyLatsis
Copy link
Collaborator Author

AnthonyLatsis commented Apr 19, 2019 •
edited
Loading

Looks like a clang conflict. I guess I must do a clean build & rebase after all.

@AnthonyLatsis AnthonyLatsis force-pushed the cleanup-func-subscript-validation branch from 565a2ef to 00e6ae1 Compare April 19, 2019 21:16
@AnthonyLatsis
Copy link
Collaborator Author

AnthonyLatsis commented Apr 19, 2019 •
edited
Loading

Excuse the delay, it took a while to update everything. I also merged in the new logic for opaque return types, here is the relevant diff.

@slavapestov
Copy link
Contributor

@swift-ci Please smoke test

@slavapestov
Copy link
Contributor

@swift-ci Please test source compatibility

@AnthonyLatsis
Copy link
Collaborator Author

AnthonyLatsis commented Apr 20, 2019 •
edited
Loading

Hm. Both of these fails don't seem related to the change. Although looking at the logs I can barely tell what happened to Source Compat at such an early stage.

@slavapestov
Copy link
Contributor

@swift-ci Please smoke test Linux

@slavapestov slavapestov merged commit 8ec0e39 into swiftlang:master Apr 21, 2019
@slavapestov
Copy link
Contributor

Thank you!

@AnthonyLatsis AnthonyLatsis deleted the cleanup-func-subscript-validation branch February 17, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnthonyLatsis @slavapestov