-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to argument parser 1.2.2 #63521
Conversation
This version won't work with SwiftPM, we need one that includes apple/swift-argument-parser#548, which hasn't been tagged yet AFAIU |
in what way? it builds okay afaict |
It may build using SwiftPM, but the bootstrap script will fail due to a regression that was introduced in 1.2.0 and that apple/swift-argument-parser#548 fixes. |
@natecook1000 do we need a tag then? |
@tomerd Just tagged 1.2.2, which has the fix that @MaxDesiatov mentioned 👍🏻 |
seems unrelated |
@compnerd do we need to fix anything for the windows build to pass? |
This seems like something else?
|
@swift-ci please build toolchain Windows platform |
Please test with following PRs: @swift-ci please build toolchain windows platform |
Please test with following PRs: @swift-ci please test Windows platform |
Updated the title to match the tag version (1.2.2) |
update argument parser to version 1.2.0