Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to argument parser 1.2.2 #63521

Merged
merged 2 commits into from
Feb 13, 2023
Merged

update to argument parser 1.2.2 #63521

merged 2 commits into from
Feb 13, 2023

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented Feb 8, 2023

update argument parser to version 1.2.0

@tomerd tomerd requested a review from shahmishal as a code owner February 8, 2023 17:44
@tomerd
Copy link
Contributor Author

tomerd commented Feb 8, 2023

cc @natecook1000 @MaxDesiatov

@MaxDesiatov
Copy link
Contributor

This version won't work with SwiftPM, we need one that includes apple/swift-argument-parser#548, which hasn't been tagged yet AFAIU

@tomerd
Copy link
Contributor Author

tomerd commented Feb 8, 2023

@tomerd
Copy link
Contributor Author

tomerd commented Feb 8, 2023

This version won't work with SwiftPM, we need one that includes apple/swift-argument-parser#548, which hasn't been tagged yet AFAIU

in what way? it builds okay afaict

@MaxDesiatov
Copy link
Contributor

in what way? it builds okay afaict

It may build using SwiftPM, but the bootstrap script will fail due to a regression that was introduced in 1.2.0 and that apple/swift-argument-parser#548 fixes.

@tomerd
Copy link
Contributor Author

tomerd commented Feb 8, 2023

It may build using SwiftPM, but the bootstrap script will fail due to a regression that was introduced in 1.2.0 and that apple/swift-argument-parser#548 fixes.

@natecook1000 do we need a tag then?

@natecook1000
Copy link
Member

@tomerd Just tagged 1.2.2, which has the fix that @MaxDesiatov mentioned 👍🏻

@tomerd
Copy link
Contributor Author

tomerd commented Feb 10, 2023

@tomerd
Copy link
Contributor Author

tomerd commented Feb 10, 2023

@tomerd
Copy link
Contributor Author

tomerd commented Feb 10, 2023

Failed Tests (1):
  Swift(iphonesimulator-x86_64) :: SourceKit/CursorInfo/static_vs_class_spelling.swift

seems unrelated

@tomerd
Copy link
Contributor Author

tomerd commented Feb 11, 2023

@tomerd
Copy link
Contributor Author

tomerd commented Feb 11, 2023

@compnerd do we need to fix anything for the windows build to pass?

@compnerd
Copy link
Member

This seems like something else?

LLVM ERROR: out of memory

Allocation failed

@compnerd
Copy link
Member

@swift-ci please build toolchain Windows platform

@compnerd
Copy link
Member

Please test with following PRs:
swiftlang/swift-driver#1285
swiftlang/swift-package-manager#6131
swiftlang/sourcekit-lsp#708

@swift-ci please build toolchain windows platform

@compnerd
Copy link
Member

Please test with following PRs:
swiftlang/swift-driver#1285
swiftlang/swift-package-manager#6131
swiftlang/sourcekit-lsp#708

@swift-ci please test Windows platform

@shahmishal shahmishal changed the title update to argument parser 1.2.0 update to argument parser 1.2.2 Feb 13, 2023
@shahmishal
Copy link
Member

Updated the title to match the tag version (1.2.2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants