[5.9][Driver] Remove unused runtime library path on non-Darwin platforms #66745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Translation of swiftlang/swift-driver#1374 to the legacy C++ Driver, with the addition of a test.
|
This is a no-brainer for main, but is there any actual need to get it into 5.9? After branch we generally don't want to take changes that aren't actually needed for the release. |
|
@stephentyrone, I figured it's worth cleaning up for the next release too, but wasn't planning on submitting it for 5.8, since that already released. |
|
@artemcm, please run the CI on this backport too. |
|
@swift-ci test |
|
@artemcm, this is the legacy driver backport of the just-merged swiftlang/swift-driver#1381, ready to go in too. |
|
Ping @nkcsgexi, this 5.9 legacy driver is currently out of sync with swiftlang/swift-driver#1381 till this goes in. |
|
@DougGregor, simple matching pull for the swift-driver, please review. |
nkcsgexi
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick of #66546
Explanation: As detailed in the linked issue, the compiler currently looks in
/sdk/usr/lib/swift/if an-sdkis explicitly specified, which may be needed for Darwin platforms, but is unused on non-Darwin. This is a translation of swiftlang/swift-driver#1381 to the legacy C++ Driver, with the addition of a test.Scope: Only affects an unused library path on non-Darwin platforns
Issue: #63416
Risk: low, as nobody appears to use it
Testing: Passed all CI on trunk
Reviewer: @artemcm