[rebranch] Various changes to get rebranch compiling after taking new clang branch #74851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
requested review from
ahoppen,
hamishknight,
rintaro,
zoecarver,
hyp,
egorzhdan,
beccadax,
ian-twilightcoder,
hborla,
slavapestov and
xedin
as code owners
|
@egorzhdan and @beccadax for clang importer changes. @aschwaighofer for IRGen/SIL. |
|
@swift-ci please test |
This was referenced Jun 30, 2024
`llvm::erase_value` was deprecated and removed.
`requires` was removed and replaced with `ASSERT`.
…Loc` This was changed in upstream LLVM 142c3f394e1b34dcefcaf0887a6fd4711b78eeb3.
bnbarham
force-pushed
the
rebranch-build-after-branch
branch
from
ffc2864 to
35fd6c7
Compare
|
@swift-ci please test |
bnbarham
force-pushed
the
rebranch-build-after-branch
branch
from
35fd6c7 to
fc95999
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
egorzhdan
approved these changes
Jul 2, 2024
aschwaighofer
approved these changes
Jul 2, 2024
compnerd
approved these changes
Jul 2, 2024
compnerd
approved these changes
Jul 2, 2024
`getSelector` now takes a `const clang::IdentifierInfo *` `ArrayRef`. Sprinkle a bunch of `const`s in.
`Sema` was split up in LLVM upstream 31a203fa8af47a8b2e8e357857b114cf90638b2eq.
Use `FeatureName` rather than `first`.
There were a number of upstream LLVM changes to `DeclID` in order to separate "local" and "global" IDs: llvm/llvm-project@07b1177 llvm/llvm-project@b8e3b2a llvm/llvm-project@b467c6b llvm/llvm-project#89873 llvm/llvm-project@d86cc73 llvm/llvm-project@8af8602 ... and probably more. This likely needs further cleaning up to not use `DeclID` at all.
Remove `deque` from files it isn't actually used in. Add it and `stack` to files that it is - presumably they were previously transitively found through other includes.
bnbarham
force-pushed
the
rebranch-build-after-branch
branch
from
fc95999 to
aa7a3a8
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
Heaps more failures than when I checked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.