Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cxx-interop][rebranch] Print inline instead of static inline for template specializations #75418

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

egorzhdan
Copy link
Contributor

This fixes a number of test failures in reverse C++ interop.

Clang's behavior was changed in llvm/llvm-project#93873, and it no longer accepts the C++ headers that Swift generates.

rdar://132283247

@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Jul 23, 2024
@egorzhdan egorzhdan requested review from Xazax-hun and ahatanaka July 23, 2024 17:40
@egorzhdan egorzhdan requested review from zoecarver and hyp as code owners July 23, 2024 17:40
@egorzhdan egorzhdan force-pushed the egorzhdan/rebranch-static-template branch from ded0baa to 91a5d2e Compare July 23, 2024 17:41
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

Copy link
Contributor

@Xazax-hun Xazax-hun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

… template specializations

This fixes a number of test failures in reverse C++ interop.

Clang's behavior was changed in llvm/llvm-project#93873, and it no longer accepts the C++ headers that Swift generates.

rdar://132283247
@egorzhdan egorzhdan force-pushed the egorzhdan/rebranch-static-template branch from 91a5d2e to 14413d9 Compare July 24, 2024 12:02
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan
Copy link
Contributor Author

None of the test failures are caused by this change, and the reverse interop tests are passing on macOS.

@egorzhdan egorzhdan merged commit 385e616 into rebranch Jul 24, 2024
0 of 3 checks passed
@egorzhdan egorzhdan deleted the egorzhdan/rebranch-static-template branch July 24, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants