Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aria Roles added for Improved Accessibility #1978

Merged
merged 10 commits into from
Apr 20, 2021
Merged

Conversation

amyspeed
Copy link
Contributor

@amyspeed amyspeed commented Mar 8, 2021

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Data tables are not properly being read by screen readers. The cells are not being associated with column headers. In order to pass accessibility scans, aria roles are needed.

What is the new behavior?
Aria roles have been added. Screen readers can associate the data in the cells with their corresponding rows, columns, and column headers.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@Hypercubed Hypercubed merged commit 39d5b0d into swimlane:master Apr 20, 2021
@gonzalobustos gonzalobustos mentioned this pull request May 28, 2021
7 tasks
@GaithD
Copy link

GaithD commented Jul 29, 2021

Hi, when this fix will be in a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants