Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing inline editing from manifesto #2057

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Removing inline editing from manifesto #2057

merged 1 commit into from
Jan 7, 2022

Conversation

jogaj
Copy link
Contributor

@jogaj jogaj commented Jan 7, 2022

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: Update Manifesto

What is the current behavior? (You can also link to an open issue here)
In the manifesto section there is a line saying that the "inline editor" is one feature that will not be implemented but if you check the live samples there is one sample about inline editor

What is the new behavior?
The "inline editor" is not shown in the manifesto

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

Current manifesto
image

Current live examples
image

Copy link

@Jospeva1210 Jospeva1210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jogaj jogaj merged commit 440ae8b into master Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants