perf(system): reduce getter accesses

swordev · May 13, 2023 · 5c0eb07 · 5c0eb07
1 parent c2226ae
commit 5c0eb07
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/.changeset/orange-bees-wave.md b/.changeset/orange-bees-wave.md
@@ -0,0 +1,5 @@
+---
+"@suid/system": patch
+---
+
+Reduce accesses to getter properties
diff --git a/packages/system/src/createStyled.tsx b/packages/system/src/createStyled.tsx
@@ -213,13 +213,11 @@ function createStyled<
           $component,
           mergeProps(otherProps, {
             get children() {
-              return (otherProps as any).children;
+              return (inProps as any).children;
             },
             // [review] This property must be omitted on each component individually.
             get component() {
-              return is$ComponentStyled()
-                ? (otherProps as any).component
-                : null;
+              return is$ComponentStyled() ? (inProps as any).component : null;
             },
             get as() {
               return isComponentStyled ? inProps.as : undefined;